A build problem with flymake.info

A build problem with flymake.info

[martin rudalics]

With separate build directories making the texi files currently fails as

../../../doc/misc/flymake.texi:7: @include `../emacs/docstyle.texi': No such file or directory.
make[2]: *** [../../../doc/misc/../../info/flymake.info] Error 1

Second builds usually succeed.  Is there any reason for flymake.texi to
have and/or hardcode @include ../emacs/docstyle.texi?

martin

Re: A build problem with flymake.info

[João Távora]

martin rudalics <rudalics@gmx.at> writes:

> With separate build directories making the texi files currently fails as
>
> ../../../doc/misc/flymake.texi:7: @include `../emacs/docstyle.texi': No such file or directory.
> make[2]: *** [../../../doc/misc/../../info/flymake.info] Error 1

Sorry, I broke it again with 15f4cdd873:

      Mention use of C-h . (display-local-help) in Flymake manual
     
      Fixes: Bug#31921

This is something I had previously fixed with 0d0265bf50e190

      Fix @include directive in Flymake doc
     
      * doc/misc/flymake.texi: Don't @include a relative path.

I just pushed a new fix in 77deaf9a1d750

> Second builds usually succeed.  Is there any reason for flymake.texi to
> have and/or hardcode @include ../emacs/docstyle.texi?

I sometimes change the line to `../emacs/docstyle.texi` so I can build
quickly with C-c C-c while editing the file.  Then I forget to take it out.  I

I wish Texinfo mode had some load path variable or something exposed to
elisp that I could use to avoid this bug and still benefit from snappy
C-c C-c's.  Or some other local-variable or dir-variable based
mechanism...

João

Re: A build problem with flymake.info

[Eli Zaretskii]

> From: João Távora <joaotavora@gmail.com>
> Date: Sat, 28 Jul 2018 08:47:36 +0100
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
> I wish Texinfo mode had some load path variable or something exposed to
> elisp that I could use to avoid this bug and still benefit from snappy
> C-c C-c's.  Or some other local-variable or dir-variable based
> mechanism...

Why not add such a feature to texinfmt.el?  It doesn't sound hard to
do that.

Re: A build problem with flymake.info

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 819 bytes --]

I tried, looked around, but iirc it wasn't easy, or I was afraid of
breaking something. Or maybe it was that not all texinfo processors support
that feature. Maybe i was looking in the wrong place, I don't remember.

Anyway, if you know an easier way, I'm all ears.

Thanks!

On Sat, Jul 28, 2018, 09:05 Eli Zaretskii <eliz@gnu.org> wrote:

> > From: João Távora <joaotavora@gmail.com>
> > Date: Sat, 28 Jul 2018 08:47:36 +0100
> > Cc: emacs-devel <emacs-devel@gnu.org>
> >
> > I wish Texinfo mode had some load path variable or something exposed to
> > elisp that I could use to avoid this bug and still benefit from snappy
> > C-c C-c's.  Or some other local-variable or dir-variable based
> > mechanism...
>
> Why not add such a feature to texinfmt.el?  It doesn't sound hard to
> do that.
>

[-- Attachment #2: Type: text/html, Size: 1364 bytes --]

Re: A build problem with flymake.info

[Eli Zaretskii]

> From: João Távora <joaotavora@gmail.com>
> Date: Sat, 28 Jul 2018 09:39:42 +0100
> Cc: martin rudalics <rudalics@gmx.at>, emacs-devel <emacs-devel@gnu.org>
> 
> I tried, looked around, but iirc it wasn't easy, or I was afraid of breaking something. Or maybe it was that not
> all texinfo processors support that feature. Maybe i was looking in the wrong place, I don't remember.
> 
> Anyway, if you know an easier way, I'm all ears.

Maybe there's a misunderstanding on my part: where (in what commands)
did you need this, and in which use cases?  IOW, can you describe in
more detail what are the situations where you need to modify the
@include lines, and why?

Re: A build problem with flymake.info

[João Távora]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: João Távora <joaotavora@gmail.com>
>> Date: Sat, 28 Jul 2018 09:39:42 +0100
>> Cc: martin rudalics <rudalics@gmx.at>, emacs-devel <emacs-devel@gnu.org>
>> 
>> I tried, looked around, but iirc it wasn't easy, or I was afraid of
>> breaking something. Or maybe it was that not all texinfo processors
>> support that feature. Maybe i was looking in the wrong place, I don't
>> remember.
>> 
>> Anyway, if you know an easier way, I'm all ears.
>
> Maybe there's a misunderstanding on my part: where (in what commands)
> did you need this, and in which use cases?

C-c C-c, which is bound to TeX-command-master when using the non-core
AucTex package.  But the problem also happens with Emacs's built-in
C-c RET C-b (makeinfo-buffer)

TeX-command-master is where I tried fixing it, so it may be easier in
Emacs's built-in makeinfo.el, which is where makeinfo-buffer hails from.

(For those curious, TeX-command-master is a command multiplexer designed
to understand what the next logical command for a certain file is (e.g
first compiling, then viewing, etc...)  It works fine with latex files
and doc/misc/flymake.texi, except for the load-path issue)

> IOW, can you describe in more detail what are the situations where you
> need to modify the @include lines, and why?

  <from emacs checkout dir>
  src/emacs -Q
  C-x C-f RET doc/misc/flymake.texi RET   ; find the file
  C-c RET C-b RET                         ; makeinfo-buffer

If I don't modify the include line, this errors.  If I modify it, it
succeeds and presents the updated info buffer.

João

Re: A build problem with flymake.info

[Eli Zaretskii]

> From: João Távora <joaotavora@gmail.com>
> Cc: rudalics@gmx.at,  emacs-devel@gnu.org
> Date: Sat, 28 Jul 2018 14:27:37 +0100
> 
> > Maybe there's a misunderstanding on my part: where (in what commands)
> > did you need this, and in which use cases?
> 
> C-c C-c, which is bound to TeX-command-master when using the non-core
> AucTex package.  But the problem also happens with Emacs's built-in
> C-c RET C-b (makeinfo-buffer)
> 
> TeX-command-master is where I tried fixing it, so it may be easier in
> Emacs's built-in makeinfo.el, which is where makeinfo-buffer hails from.

If you can use makeinfo.el, you should be able to customize
makeinfo-options to include the "-P DIR" option, which prepends DIR to
the @include search path.  Does that fit the bill?

Re: A build problem with flymake.info

[João Távora]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: João Távora <joaotavora@gmail.com>
>> Cc: rudalics@gmx.at,  emacs-devel@gnu.org
>> Date: Sat, 28 Jul 2018 14:27:37 +0100
>> 
>> > Maybe there's a misunderstanding on my part: where (in what commands)
>> > did you need this, and in which use cases?
>> 
>> C-c C-c, which is bound to TeX-command-master when using the non-core
>> AucTex package.  But the problem also happens with Emacs's built-in
>> C-c RET C-b (makeinfo-buffer)
>> 
>> TeX-command-master is where I tried fixing it, so it may be easier in
>> Emacs's built-in makeinfo.el, which is where makeinfo-buffer hails from.
>
> If you can use makeinfo.el, you should be able to customize
> makeinfo-options to include the "-P DIR" option, which prepends DIR to
> the @include search path.

> Does that fit the bill?

Yes, it does (for makeinfo). So thanks! How about adding this to the
file's local variables?

João

  diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi
  index bda7e1428b..e39be578b7 100644
  --- a/doc/misc/flymake.texi
  +++ b/doc/misc/flymake.texi
  @@ -1158,3 +1158,7 @@ Index
   @printindex cp
   
   @bye
  +
  +@c Local Variables:
  +@c makeinfo-options: "--fill-column=70 -P ../emacs"
  +@c End:

Re: A build problem with flymake.info

[Eli Zaretskii]

> From: João Távora <joaotavora@gmail.com>
> Cc: rudalics@gmx.at,  emacs-devel@gnu.org
> Date: Wed, 01 Aug 2018 09:03:25 +0100
> 
> Yes, it does (for makeinfo). So thanks! How about adding this to the
> file's local variables?
> 
> João
> 
>   diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi
>   index bda7e1428b..e39be578b7 100644
>   --- a/doc/misc/flymake.texi
>   +++ b/doc/misc/flymake.texi
>   @@ -1158,3 +1158,7 @@ Index
>    @printindex cp
>    
>    @bye
>   +
>   +@c Local Variables:
>   +@c makeinfo-options: "--fill-column=70 -P ../emacs"
>   +@c End:

I don't see why not, but please add a comment there explaining why we
do this, as other Texinfo files don't.

Re: A build problem with flymake.info

[martin rudalics]

> I just pushed a new fix in 77deaf9a1d750

Thanks for the fix, martin