From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#32319: 27.0.50; flyspell-mode error on start Date: Sat, 04 Aug 2018 22:21:47 -0700 Message-ID: <87tvo9pevo.fsf@ericabrahamsen.net> References: <87o9eoldcv.fsf@ericabrahamsen.net> <834lgfpggw.fsf@gnu.org> <87600ug7wx.fsf@ericabrahamsen.net> <83effiocc9.fsf@gnu.org> <87d0v1vp9h.fsf@ericabrahamsen.net> <83ftzutmw4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533446407 8759 195.159.176.226 (5 Aug 2018 05:20:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Aug 2018 05:20:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 32319@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 05 07:20:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmBSU-0002A7-IZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Aug 2018 07:20:02 +0200 Original-Received: from localhost ([::1]:57152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmBUa-0002ae-Ug for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Aug 2018 01:22:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmBUR-0002aS-Dx for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2018 01:22:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmBUQ-0005jI-GU for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2018 01:22:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36228) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmBUQ-0005jA-C5 for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2018 01:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fmBUQ-0002Bi-6L for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2018 01:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Aug 2018 05:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32319 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32319-submit@debbugs.gnu.org id=B32319.15334465128392 (code B ref 32319); Sun, 05 Aug 2018 05:22:02 +0000 Original-Received: (at 32319) by debbugs.gnu.org; 5 Aug 2018 05:21:52 +0000 Original-Received: from localhost ([127.0.0.1]:41246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmBUG-0002BI-0w for submit@debbugs.gnu.org; Sun, 05 Aug 2018 01:21:52 -0400 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:39797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmBUE-0002BA-6W for 32319@debbugs.gnu.org; Sun, 05 Aug 2018 01:21:50 -0400 Original-Received: from localhost (97-113-227-87.tukw.qwest.net [97.113.227.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 67FD6C3569; Sun, 5 Aug 2018 05:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1533446509; bh=28uDbvxq/dvCJxnOv1CRI1WarIAPhyHWkxU4qV4a1yE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=f3TMOReBwNahUQ0yKMjQMXVx9gY9NjjqE1XORubI8b/zLfoaZc8FzRqbDIVF7055T Lraoiyj48gmmQl6JaHLFWD+GtF7OZuX+3r9CvjdpMSer3KRzgSVcXAhaE9FtzkJHXu cUoV2Ln5SNe1w0Zw/Qo2UYJ6RjxdB56TZlhI8KgA= In-Reply-To: <83ftzutmw4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 04 Aug 2018 14:02:51 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149267 Archived-At: Eli Zaretskii writes: >> From: Eric Abrahamsen >> Cc: 32319@debbugs.gnu.org >> Date: Wed, 01 Aug 2018 12:51:54 -0700 >> >> If the symlink is not present, the "hunspell -D" output looks like: >> >> SEARCH PATH:.:: >> AVAILABLE DICTIONARIES >> /usr/share/hunspell/en_TT >> >> Can't open affix or dictionary files for dictionary named "en_US". >> >> IOW, there's no line that matches "\\.aff$", and >> `hunspell-default-dictionary' is never set, and the error is raised in >> line 1177, where it's assumed that that variable has a value. >> >> So things go wrong pretty early on, as soon as Hunspell fails to load a >> dictionary. > > Does the patch below produce a useful diagnostic? This patch is just fine, and would certainly be a lot better than the current situation. I only note that, if we allow this function to fail silently, the error you get *later on*, when you try to use flyspell to do something, comes directly from hunspell and says exactly what the problem is (ie, which dictionary it tried and failed to load). That's even more helpful. If we did that, this function could just call `ispell-print-if-debug' and log the failure quietly. But raising an error directly is also fine, and might be preferable in order to avoid creating weird problems further down the line. Eric