bug#33309: Add flatten-list?

["Basil L. Contovounesios" <contovob@tcd.ie>]

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

[Sorry, Alex, for sending this to you twice - I accidentally made my
 last message a narrow, rather than wide, reply.]

Alex Branham <alex.branham@gmail.com> writes:

> Thanks for the feedback, everyone.

Thanks for working on this.

> Here's a patch that implements `flatten-tree' which always returns a
> list and recurses into conses.

Given Emacs' recursive limitations, wouldn't an iterative implementation
be better?  For instance, the following currently blows
max-specpdl-size:

  (length (flatten-tree (make-list 800 nil)))

How about something like the following?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: flatten-tree.diff --]
[-- Type: text/x-diff, Size: 851 bytes --]

diff --git a/lisp/subr.el b/lisp/subr.el
index f7eac75305..3fed3bc436 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -5453,10 +5453,15 @@ flatten-tree
 This always returns a list containing all the elements of TREE.
 \(flatten-tree \\='(1 (2 3 (4 5 (6))) 7))
 => (1 2 3 4 5 6 7)"
-  (cond ((null tree) nil)
-        ((consp tree) (append (flatten-tree (car tree))
-                              (flatten-tree (cdr tree))))
-        (t (list tree))))
+  (let (elems)
+    (setq tree (list tree))
+    (while (let ((elem (pop tree)))
+             (cond ((consp elem)
+                    (setq tree (cons (car elem) (cons (cdr elem) tree))))
+                   (elem
+                    (push elem elems)))
+             tree))
+    (nreverse elems)))
 
 ;; Technically, `flatten-list' is a misnomer, but we provide it here
 ;; for discoverability:

[-- Attachment #3: Type: text/plain, Size: 11 bytes --]


-- 
Basil