From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33870: 27.0.50; xref-goto-xref not configurable Date: Sat, 19 Jan 2019 22:35:30 +0200 Organization: LINKOV.NET Message-ID: <87tvi4jtv9.fsf@mail.linkov.net> References: <87a7ktqqx7.fsf@mail.linkov.net> <9215183d-0a44-88b5-5b3c-d0da31f749ad@yandex.ru> <878t02egph.fsf@mail.linkov.net> <874lak9kr0.fsf@mail.linkov.net> <87zhscklhq.fsf@gmail.com> <87bm4qel4t.fsf@mail.linkov.net> <67c9abb5-f546-361f-04ca-da96ceaca4e2@yandex.ru> <87bm4le0tm.fsf@mail.linkov.net> <87imys6x5s.fsf@mail.linkov.net> <87imyskvia.fsf@gmail.com> <5C420DF3.7090908@gmx.at> <87pnstppvw.fsf@gmail.com> NNTP-Posting-Host: ciao.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ciao.gmane.org 1547935049 142799 195.159.176.228 (19 Jan 2019 21:57:29 GMT) X-Complaints-To: usenet@ciao.gmane.org NNTP-Posting-Date: Sat, 19 Jan 2019 21:57:29 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33870@debbugs.gnu.org, Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 19 22:57:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1gkycG-000b6u-UY for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jan 2019 22:57:25 +0100 Original-Received: from localhost ([127.0.0.1]:60325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkycP-0002tc-La for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jan 2019 16:57:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkyax-0001tX-EK for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 16:56:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkyaw-0003M1-O0 for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 16:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkyaw-0003Le-KV for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 16:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gkyaw-0004uK-94 for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 16:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jan 2019 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33870-submit@debbugs.gnu.org id=B33870.154793490518744 (code B ref 33870); Sat, 19 Jan 2019 21:56:02 +0000 Original-Received: (at 33870) by debbugs.gnu.org; 19 Jan 2019 21:55:05 +0000 Original-Received: from localhost ([127.0.0.1]:38112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkya1-0004sF-0C for submit@debbugs.gnu.org; Sat, 19 Jan 2019 16:55:05 -0500 Original-Received: from ladybird.maple.relay.mailchannels.net ([23.83.214.98]:61881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkyZy-0004rp-Px for 33870@debbugs.gnu.org; Sat, 19 Jan 2019 16:55:03 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 24FFE1241AE; Sat, 19 Jan 2019 21:55:01 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (unknown [100.96.36.160]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B4224124197; Sat, 19 Jan 2019 21:55:00 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Sat, 19 Jan 2019 21:55:01 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Spill-Daffy: 4548132229159e3e_1547934900974_261279713 X-MC-Loop-Signature: 1547934900974:3422300917 X-MC-Ingress-Time: 1547934900974 Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 4F51480B2D; Sat, 19 Jan 2019 13:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=kYVqe51uHvmRC2jnBVZ+GPqRR+Y=; b= kfAYs4MZYTnLnmce0XrO9a88rC8L3X6Jbk+nuYxVzTL1X/Qf8uqcyBTbyYN516i1 Cwiq6sNx/U2GuOz18G1eNOjexHTtK/KwDZbt2FLTGc5ku+0AWWrTERP0tpTEWwG+ ghsX2FRAqp1wmejN7cyNSZlL2sHqyHRGUSDp291YvwM= Original-Received: from mail.jurta.org (m91-129-101-91.cust.tele2.ee [91.129.101.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id AC18F80B10; Sat, 19 Jan 2019 13:54:57 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a6 In-Reply-To: <87pnstppvw.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 18 Jan 2019 22:22:43 +0000") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrhedvgdduheeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppeeluddruddvledruddtuddrledunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtuddrledupdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepjhhorghothgrvhhorhgrsehgmhgrihhlrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154592 Archived-At: >>> I see the prototype of window--display-buffer has changed recently, and >>> so has it docstring. I assumed that was it for the cleanup Martin >>> requested, but indeed I could be wrong, as I didn't follow that >>> subthread closely (has it died down or I am just not Cc: anymore?). >> >> The cleanup has been done. The final message of that subthread says: >> >> Anyone interested in renaming 'window--display-buffer' - please go >> ahead. I think a 'display-buffer-' prefix should then be appropriate. >> >> What I meant there is that calling it say 'display-buffer-in-window' >> would be appropriate but the final name is up to its clients. > > Actually seems like a really good name. If I make a function alias, > code in window.el can still use the old name. Do you prefer that, or > should I replace all uses that I can find in Emacs? I agree that 'display-buffer-in-window' is a good name. > Actually2, we should keep the old name. A code search on github.com > reveals that other packages/customizations are using the internal > function, too (which now takes one less arg, but if they break for that, > they were really asking for it). Then better to keep the old name with its old signature and declare it obsolete and replace its body with the call to the function with the new name and one less arg.