From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Branch freezing for release (WAS: bug#34776) Date: Wed, 10 Apr 2019 04:57:09 -0400 Message-ID: <87tvf69r16.fsf_-_@gmail.com> References: <871s3jeh8m.fsf@ericabrahamsen.net> <87zhq4zzcz.fsf@ericabrahamsen.net> <871s3a90qo.fsf@ericabrahamsen.net> <87imvmbube.fsf@gmail.com> <87mukyiczg.fsf@ericabrahamsen.net> <877ec2iau1.fsf@ericabrahamsen.net> <4CAA6D9F-0402-489C-8DD1-CE2ADBAA42C9@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="239079"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) Cc: Eric Abrahamsen , To: Emacs developers , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 10 10:57:28 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hE92t-00104N-O8 for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 10:57:27 +0200 Original-Received: from localhost ([127.0.0.1]:56011 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE92s-00089X-MV for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 04:57:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE92l-00089P-PD for emacs-devel@gnu.org; Wed, 10 Apr 2019 04:57:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE92k-0002gd-9d for emacs-devel@gnu.org; Wed, 10 Apr 2019 04:57:19 -0400 Original-Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]:39586) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hE92h-0002ea-Q9; Wed, 10 Apr 2019 04:57:16 -0400 Original-Received: by mail-qt1-x833.google.com with SMTP id t28so1931103qte.6; Wed, 10 Apr 2019 01:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jpUZaQS5oG7J2JSeagMbPVXmg4NjRdHR9gHn/kv0l/o=; b=LQ0VqSKkRL5zWfHcvlzFF5X0WJjS7bQTnydNxhoaFoRt64i0qUvHYMg42anizxTioW Bw0DegP+SI2JxGWI+NzBMEbcvukbdXrj0Kxkk5v5s4WH/MGA3uZ8aGlJBTgm6g01mg0a fGBsIymGkLuOH6hyBdGQRilP1xu3PuoVIZbp9OqtP2WRF8C5ka0s60MmRbYlrHMs4Lrd 550QWKMzHIOXED8TRJT4qUydJmFPTQteBUSGNsK3nMSEqqxoa/heg8STgzGx0qT5Ar+p jUlSiHhL6hPLk9Tu7xdFBLOZFUFiaMxMTFpz4jkcH6Ft6DS9V2QxR3GdMa8mHIcYa07z ZqDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jpUZaQS5oG7J2JSeagMbPVXmg4NjRdHR9gHn/kv0l/o=; b=rkelx3CeMgz/pjCyS8p/0Lj0YO6ECNxRmeLQh0CEWxhG/36QDPmUJ/3bE4gCCR7++r 3YP4Owxd1A6UcgGcL/ydMB3BRwah0vHa+DKQ0/2tTrs5bE1IlMtEd9wWMhnSMQocbOJ+ aOyfZd/qQScIPJJqjwOxYllHzSU8lQPj41ZTsG71jupCtvVc1syu7xN0QoOXwzlIqHQ5 7WFKHxtQ9MRz/GEJxA0rtEPwha81B3r5JdSFqyHV9gUCARDiEg3AQ9+oGTrs4rrauJHt I7L+jX5OsOFOwHR8fq+/f6G2KFQiGrf0jm3YbghYjPweVelWrLAIMeuHVJ22MPSqahG7 A5wQ== X-Gm-Message-State: APjAAAWyBoNK80991Hz/H84fCgnAQVs+B0OmCJzesH5/WrpanffKeRGF SHRXzBAySSmWpYEIdqzd3lyNkNY5 X-Google-Smtp-Source: APXvYqwCh3xVeJ5GgGwxPNwktMreGm6y5Cj9Uzqf55YielDcn/MeSm7HT4UxMAK6i6QmExvJHO3uTg== X-Received: by 2002:ac8:34a2:: with SMTP id w31mr34421513qtb.164.1554886632596; Wed, 10 Apr 2019 01:57:12 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d41sm25217207qtd.90.2019.04.10.01.57.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Apr 2019 01:57:11 -0700 (PDT) In-Reply-To: <4CAA6D9F-0402-489C-8DD1-CE2ADBAA42C9@gnu.org> (Eli Zaretskii's message of "Wed, 10 Apr 2019 11:24:41 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::833 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235193 Archived-At: >>>>>> The RC said Emacs 26.2 was to be released March 27... Part of >>>>>> making a release is for people to stop changing that branch. >>>>> >>>>> Unfortunately, that ship has sailed, since within an hour of RC >>>>> release a new commit was pushed to the release branch [...] >>>> This sounds like a job for a git hook. I pay fairly close >>>> attention to emacs.devel for someone who isn't an Emacs dev, and >>>> apparently I missed this billboard. >>> >>> Not sure which billboard jou think you missed, but in general, I >>> don't see here any problem for which a commit hook would be a good >>> solution. The existing hooks are already annoying enough, and are >>> too easy to bypass to be reliable. Git supports server-side hooks which can't be bypassed. If I read githooks(5) correctly, then putting an update hook on the server with contents: if [ "$1" = emacs-26 ]; then echo "Branch $1 is frozen" exit 1 fi would do it. There would still be some additional complication with letting in the commit for the RC itself though. Andreas' suggestion to just let unexpected commits miss being in the release seems simpler. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34776#61 >> What I meant was: if 200 people have the ability to push to the repo, >> but 50 of them aren't checking the mailing lists regularly, then you >> call a halt to an RC, that's 50 people who don't know they shouldn't >> push. It seems like a lot more work to chase after those 50 than to >> close the gate and reject pushes to that particular release. > > There's no need to check the mailing list, this stuff is in > CONTRIBUTE. That's why I never called for any halts. CONTRIBUTE says: Doc fixes are always considered "safe" -- even when a release branch is in feature freeze, it can still receive doc fixes. I don't see anything there about not pushing after an RC is made (and how would someone know about the RC without checking the mailing list?)