From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31676: 27.0.50; More helpful error message for unescaped character literals Date: Fri, 19 Apr 2019 07:43:47 -0400 Message-ID: <87tveuusng.fsf@gmail.com> References: <837en9uyaq.fsf@gnu.org> <83k1r7sw7m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="183055"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Lars Ingebrigtsen , 31676@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 19 13:44:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHRwI-000lVj-4d for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Apr 2019 13:44:18 +0200 Original-Received: from localhost ([127.0.0.1]:55270 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHRwH-0002FL-4q for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Apr 2019 07:44:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHRw8-0002EL-RZ for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 07:44:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHRw7-00083M-Jy for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 07:44:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58219) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHRw2-0007zb-Re for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 07:44:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hHRw2-0005Ii-Jt for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 07:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Apr 2019 11:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31676 X-GNU-PR-Package: emacs Original-Received: via spool by 31676-submit@debbugs.gnu.org id=B31676.155567423820358 (code B ref 31676); Fri, 19 Apr 2019 11:44:02 +0000 Original-Received: (at 31676) by debbugs.gnu.org; 19 Apr 2019 11:43:58 +0000 Original-Received: from localhost ([127.0.0.1]:43530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHRvy-0005II-3K for submit@debbugs.gnu.org; Fri, 19 Apr 2019 07:43:58 -0400 Original-Received: from mail-qk1-f179.google.com ([209.85.222.179]:33696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHRvv-0005I3-5I for 31676@debbugs.gnu.org; Fri, 19 Apr 2019 07:43:57 -0400 Original-Received: by mail-qk1-f179.google.com with SMTP id k189so2809975qkc.0 for <31676@debbugs.gnu.org>; Fri, 19 Apr 2019 04:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=B43mbyN3F/74sbzrw/3lp/GseJXmn2WbQJqFud5YrXg=; b=nr5Knv4fefglLNJUfa5fEeaOK1cNQVCE8ccEDO5aayBCp7afD+wV4ih8I1fOUe+nAv rwu/gZolvs5oHhfx6ygE6LJ3i++5U/7mxpPff8ADVKUn+B8AimwonxHTdhRx3SbAnn/3 rJgGYI+9jzWQR0XaYxc7+dtsA7ijsVGyTOjFIPJ3f88rst6vJ366MN2eNjcuQrpbQeqz 5uYo7QPHQq0PKXitoKI0BrGy1S+7rPSTOqRFw6dvseEJlxH31yUliQClEPuv5aZ3yBKn fQashMGmiq2xuT99j5xNypWltenLmPaEJHJo8QiBPQVsG2FUJfvSWzsr9H88S5qGArIK 6WdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=B43mbyN3F/74sbzrw/3lp/GseJXmn2WbQJqFud5YrXg=; b=EGxGqWfb2trbUvADwrc4tTN+CjuLiTcI74ubiwK9KfECAmpi5jNSM/V/4AfujAIN1k n9FfyPvM5/RThl+KjDO0SyRDR/jZXTp3LFB7Dv+Ac5rh/UWTI+EbhnZw2adlOmGL/4ck qr3aGmI0g5V63fC2Lf7JI0ZNWxxyDVqTKmazgEfoo5+kurtwtcyuyDDqoDRjLuqsV+fF qKSMqrVuc5tfl1kq/oSxhxNtAfChUZCVT7ASMgFlb75cLz1Um6/sEmorakKvRCWJxa8J jGnb4u9zWiZ1jw2onTgv17eN2ZQRXsD+yQsdBjaBgt0CsAKEpiB9VmfPR5pQ/R6nXhuX wN4w== X-Gm-Message-State: APjAAAUL0gEJE3fS8GctGYfJ31pdYmyuQUrvWawyO2TjfgbKCCq071jA akJbwUtc67gRdI6lGgei7lMKexib X-Google-Smtp-Source: APXvYqybZcCCQKO+su15IYFd5cNFou6eqkjAFj3i9x6r3cmCu1errMMuUz6TUkYe7ZgJOl5GJ9EXBA== X-Received: by 2002:ae9:f71a:: with SMTP id s26mr2607889qkg.299.1555674229352; Fri, 19 Apr 2019 04:43:49 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id j39sm461454qtj.69.2019.04.19.04.43.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 04:43:48 -0700 (PDT) In-Reply-To: (Philipp Stephani's message of "Fri, 19 Apr 2019 11:54:32 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157832 Archived-At: Philipp Stephani writes: >> > The function uses an uninterned variable, so it has to be in C. I think that's slightly better than interning the >> > variable and having some Lisp function access it (the latter would have one additional internal symbol). >> Why does it need an uninterned variable? > > It doesn't need to be uninterned, but it's cleaner that way because no > other code can access the variable. > >> And if it does, why cannot >> it create a symbol that is not in obarray? > > That's what the patch does. The patch uninterns a symbol after it's interned in the obarray. I think the question is, why put the symbol in the obarray in the first place? Just a C static variable would do (although this would require an additional (trivial) C function, to use with record_unwind_protect instead of specbind). See for example Vloads_in_progress.