From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Tue, 30 Apr 2019 09:06:54 +0200 Message-ID: <87tvegt1ip.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="7459"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> To: Zhang Haijun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 30 09:08:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLMs8-0001mv-Uc for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Apr 2019 09:08:13 +0200 Original-Received: from localhost ([127.0.0.1]:40203 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLMs7-0003Bq-Qu for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Apr 2019 03:08:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLMs0-0003BW-OI for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 03:08:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLMry-00024S-U5 for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 03:08:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55225) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLMrx-00024C-RI for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 03:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLMrx-0002eO-LL for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 03:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 07:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155660802610112 (code B ref 35418); Tue, 30 Apr 2019 07:08:01 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 30 Apr 2019 07:07:06 +0000 Original-Received: from localhost ([127.0.0.1]:40536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLMr4-0002d1-1r for submit@debbugs.gnu.org; Tue, 30 Apr 2019 03:07:06 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:58501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLMr2-0002cU-EW for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 03:07:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556608015; bh=waQjiLQGNYVPVmQZnyLPcv6s+9TQ8eW92PzNrI//XkE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=LAaKYF36QUe0plSLMWmL7zXlmCVU23P333LFVSDFXUo2vabWzyJumZEARY6Po4zGF 7ky2fKePLLdCK0EKEXPY2GG8oT24AWwKMA4ohhx0DSXA+amCbisT7XjC6mpJnrRz+3 Fj+v8YnEeGWRPvAo4hSBKRkZg7Ukc4zI/u9Elo7w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.52.91]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MSv6D-1hB5TO2Wvd-00RoYt; Tue, 30 Apr 2019 09:06:55 +0200 In-Reply-To: (Zhang Haijun's message of "Tue, 30 Apr 2019 01:03:21 +0000") X-Provags-ID: V03:K1:UsRyBVVd5BNzhVrISKSUPkRq8obTPd1BNpQStVDi4RXXPktp03M PESH7r9pc0ZmiWqKjdoJx1xxoSdNcJKMovigifxm+LxD278GqUvqRSmtwNL50rXRqVc6q7y etbL4F/JPYt0ZpbbkHy74nr5OKe3zXR4IQg1l4zHdgn0l/Tv9+Blpiy7VOG1JumEYdAvUNA +MRTAnNgrg9wWYAaqCwuw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Gv5s6bMDu+8=:WHOo98mpZaRyERFJ/SrkJy Tr24Kqq1fpFNVc2xy13fDL8Q1+TV4Ob1nQaJ88+tBlPTM5gM30+jeEX42uOjDB1wa8xFsRb2p zrwZ9QtZ0zN5JxA84+K6960YN8A8qXmlQzNg/qGXC0Ms50pZN7f8qJguWBygpdSCEMyt3XY/Y T3P7p0BaiGA9rFaUyhH1dWEba/RQGfJCrc2uaQKkDZuxteaQlvHG81IBP5YsWOKIUueooCyae 5XmDaz+oEr8FQDn28o4eioE9ZVsH6Ig/oJJeEXm+m+yOc9KvGI5VTxFDX9ws3gsKQ+bPwYcfr nhDuks3tfq9OraAmN68nC2MYiH2LPq8IdMMKdmRiCBNV3j928bGe8No7vPiEttL8OA7XH8IWE RBRa8bRitVGQb2J7pkNFn+JRS+w8LZc+fFYtD21uUyzYPU+ECB+CsYHReNvEKb12mzvo8h7oU c4wYpUobd+ixeZkd7ldQMKrX+Qwzmik2LEJvy72VL/jGiz592q59uOMb8dJqYr1fx9twlA0TQ Z5fJJPtvtZZDWDIny8qvMxu3WyS/HsTqpZcVMvxyzPP6g9LtHLMzWpE+wbomrA1xxn6hK77TW H8o16gwkY+bhuunHOim04PTTSbLPEJhFp30q5sGegN9NbFQumicDwFs20dJJgFv5BMOIr34fD 5ZtIjTb5N9rlr9rEosBjWWNg9cjZYnOgY3KcnOXZLLVadWRtgc0h5fPPIsQluT32R/v8fi7ae ZHLZgVsP3kgxIe/lkgPpHf2OOHoGgnAK4YdOs4ocz5RwqwRV/bHEKjb+QAzIBpvXW27VNvOe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158480 Archived-At: Zhang Haijun writes: Hi, > diff --git a/lisp/filenotify.el b/lisp/filenotify.el > index 101ddb6be0..a4a0359328 100644 > --- a/lisp/filenotify.el > +++ b/lisp/filenotify.el > @@ -363,7 +363,7 @@ file-notify-add-watch > (setq desc (funcall > ;; kqueue does not report file changes in directory > ;; monitor. So we must watch the file itself. > - func (if (eq file-notify--library 'kqueue) file dir) > + func (if (eq file-notify--library 'kqueue11) file dir) > l-flags 'file-notify-callback))) > > ;; Modify `file-notify-descriptors=E2=80=99. I don't understand the patch. Symbol kqueue11 does not exist, so do you mean + func dir And have you applied the tests in filenotify-tests.el? Do all of them pass? Best regards, Michael.