From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Mon, 13 May 2019 17:08:45 +0200 Message-ID: <87tvdyie82.fsf@gmx.de> References: <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> <87a7fu1nv8.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="227467"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 13 17:09:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQCZt-000x3m-KO for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 17:09:21 +0200 Original-Received: from localhost ([127.0.0.1]:58918 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQCZs-0007in-4p for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 11:09:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQCZi-0007hc-Jj for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 11:09:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQCZd-0005aI-IH for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 11:09:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60616) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQCZa-0005XR-Sf for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 11:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQCZa-0006lT-Iq for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 11:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155776014125995 (code B ref 35418); Mon, 13 May 2019 15:09:02 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 13 May 2019 15:09:01 +0000 Original-Received: from localhost ([127.0.0.1]:45927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQCZY-0006lD-NY for submit@debbugs.gnu.org; Mon, 13 May 2019 11:09:00 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:48993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQCZV-0006kv-0R for 35418@debbugs.gnu.org; Mon, 13 May 2019 11:08:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557760127; bh=qZVf94id0netltkXHXAchXBoHf0iIC4hZVrIKsu/Blw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=jZMm6ItvWz5SV5SywuZMjFUb+tSST3yQD2PyXb5Sa8hhU4zfZzSnXq1ZitfQDkeir ln0AClEiLtFuusYaE0G6tEx8htgQ8y+v1eoDRM09MWpCNCblH37Pk/AwaD9xgUrJeS 05ZmEgH/4Odu2ZoIPON4e9vVSSdsBQ8U9r61XEI4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.91.238.102]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lr46Z-1gmlLQ1cOp-00ee1x; Mon, 13 May 2019 17:08:47 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 13 May 2019 13:34:59 +0200") X-Provags-ID: V03:K1:snscPRo7LZbTCMvLMjiwfqIk5t2rQgjQX55T1Ao4KA+p+dWoEvY nC3IlAhvC9sQj46RgVvf/0r5tjHgY4MON6ZUa4w+w+eQo5IUP0IswyD5K4GwG/B2WSHPp8a 20OBOseNHU5PM83GoW0PuaST3IPFKvXczWzB/zocPkUXVO3wvoAv3gxZgnPiF1RoRt2+zEF lrxYyuJDavV/SeIoU6Fzw== X-UI-Out-Filterresults: notjunk:1;V03:K0:wlHov5Ev4sg=:y4S7dahVuAgcgBQQzHyzBh TsBM6vnjYtkXdUKKT9s8Ab0bqSq1C1GNP/Q/s+PHZDn0TiAnl2b6qD2d8R3SAWiHF4vW9UmFL pNdRFKHH5TbbhcT2uB5NqDmbWgu0eM10UjPVp4gR/XAeL7oD1D1mfv1Yj1NEix3Ty7qm2FY0m PagP100SnVdF5rbM75OojgfhtQh7ZhB9ZJKKWRpDRRKF+tDyl6PZetDufy3w1wqoEfccmPF8o alPMcgCI1fTMJn+Z/WATMEshqP0MQ27OR8UI//q+oRoWaYt/WO9DVfiH09rFxUEJ71WiQFNpP v7jtDkDcSoSgkeSZAVN6TkUewrP13Bkz2PO46t/5QXfhWzcVorra23CUTeBQWTSWfXRvI9B+o 6MmoEeMByF79WbmkgDFCPglm5apAHU+MYXDhIS8F+/EkIK6yrPpksC4S3Qj9TM1YHeoll5HfW 2f3Ey/On5QbhP6gtKIfrmw0BhmVtxTZ8oqLosxlEcZEbKCTW1acT+eDYehwLlKfABxKIadJj3 Vxq2s4f5v2vaW0xvWzcT0JmlYdI5KZg0hh2f5+a+12g9fTb6j6drIUxMzGHIowEBkvT+2MQDP 881MvolLz6JZuBLdlRgKY5ZnE5xik5Fikg/Aj8pBzfDn5kAfMUCQIFZ8mIOcm3/WTY9CJgtlF 9fWbvEi5Y1QdQutb72U0SzdoAKe5AnzrEjIjInzijDD1zl2UOx6TLKznLoo0XTkxnTA/hU1Ut lrvKHLO8wRZsV20gsb0tQdFBvpwH603T6B4R+QvzgmemqDuaCmdpVqO7MC7/dy0omzS8nsH3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159186 Archived-At: Mattias Engdeg=C3=A5rd writes: Hi Mattias, >> So we must document in the Elisp manual, that buffers, which want to >> participate in global-auto-revert-mode after a renaming, shall change >> the name via set-visited-file-name. > > Are you sure about that? It sounds quite technical. But if you think it > is necessary, I'll add it. I'm not sure, of course. But how else can such a buffer participate, if we don't poll anymore (and refresh the list of buffers to be watched)? To be tested, I would say. >> Agreed. Those buffers are special (internal) anyway, it's already >> tricky to show them. Nobody needs auto-revert for invisible buffers >> :-) > > The revised patch now excludes such non-file buffers. I wonder if > buffers with file names should be excluded as well. They trivially > occur when visiting a file whose name starts with a space. `list-buffers' shows buffers with a leading space, if they are visiting a file. If they don't visit a file, they are not listed. I would say we shall apply the same rule. The patch LGTM. Do you want also add some tests to autorevert-tests.el? Best regards, Michael.