all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#36095: [PATCH] Do not use syntax-ppss-table in syntax-propertize when nil
@ 2019-06-05  9:15 Dario Gjorgjevski
  2019-06-05 11:30 ` Noam Postavsky
  0 siblings, 1 reply; 2+ messages in thread
From: Dario Gjorgjevski @ 2019-06-05  9:15 UTC (permalink / raw)
  To: 36095

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

Commit 0b3982b1a3 changed syntax-propertize to use syntax-ppss-table
explicitly, similarly to syntax-ppss.  However, it also attempts to do
this when syntax-ppss-table is nil, resulting in an error.  This patch
fixes that.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Do not use syntax-ppss-table in syntax-propertize when nil --]
[-- Type: text/x-diff, Size: 1082 bytes --]

From bfa012db3b137262cbdfff827c3b8d367750e0ab Mon Sep 17 00:00:00 2001
From: Dario Gjorgjevski <dario.gjorgjevski+git@gmail.com>
Date: Wed, 5 Jun 2019 11:07:49 +0200
Subject: [PATCH] Do not use syntax-ppss-table in syntax-propertize when nil

* lisp/emacs-lisp/syntax.el (syntax-propertize): Use (syntax-table)
instead of syntax-ppss-table when the latter is nil.
---
 lisp/emacs-lisp/syntax.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el
index 1aec1988ab..60ed531e63 100644
--- a/lisp/emacs-lisp/syntax.el
+++ b/lisp/emacs-lisp/syntax.el
@@ -304,7 +304,7 @@ syntax-propertize
 	          #'syntax-ppss-flush-cache 99 t))
       (save-excursion
         (with-silent-modifications
-          (with-syntax-table syntax-ppss-table
+          (with-syntax-table (or syntax-ppss-table (syntax-table))
             (make-local-variable 'syntax-propertize--done) ;Just in case!
             (let* ((start (max (min syntax-propertize--done (point-max))
                                (point-min)))
-- 
2.20.1


[-- Attachment #3: Type: text/plain, Size: 135 bytes --]


-- 
Dario Gjorgjevski :: <dario.gjorgjevski@gmail.com>
                  :: 744A 4F0B 4F1C 9371
                  :: +48 1525 8666837

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#36095: [PATCH] Do not use syntax-ppss-table in syntax-propertize when nil
  2019-06-05  9:15 bug#36095: [PATCH] Do not use syntax-ppss-table in syntax-propertize when nil Dario Gjorgjevski
@ 2019-06-05 11:30 ` Noam Postavsky
  0 siblings, 0 replies; 2+ messages in thread
From: Noam Postavsky @ 2019-06-05 11:30 UTC (permalink / raw)
  To: Dario Gjorgjevski; +Cc: 36095

tags 36095 fixed
close 36095 
quit

Dario Gjorgjevski <dario.gjorgjevski@gmail.com> writes:

> Commit 0b3982b1a3 changed syntax-propertize to use syntax-ppss-table
> explicitly, similarly to syntax-ppss.  However, it also attempts to do
> this when syntax-ppss-table is nil, resulting in an error.  This patch
> fixes that.

Thanks, pushed to master.

dec148939a 2019-06-05T07:29:23-04:00 "Do not use syntax-ppss-table in syntax-propertize when nil (Bug#36095)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=dec148939aad8391875e73784af2bcb0a01100bb






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-05 11:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-05  9:15 bug#36095: [PATCH] Do not use syntax-ppss-table in syntax-propertize when nil Dario Gjorgjevski
2019-06-05 11:30 ` Noam Postavsky

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.