From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#25764: 26.0.50; Make some usability improvements to sieve-script management Date: Mon, 08 Jul 2019 16:51:58 -0700 Message-ID: <87tvbw13vl.fsf@ericabrahamsen.net> References: <87vas9rg8q.fsf@ericabrahamsen.net> <87o924l0l0.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="30864"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 25764@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 09 01:53:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkdRb-0007lS-O2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Jul 2019 01:53:15 +0200 Original-Received: from localhost ([::1]:45710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkdRT-0002Rp-Ta for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jul 2019 19:53:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41676) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkdRP-0002Rj-JZ for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 19:53:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkdRO-00012S-J5 for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 19:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51172) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkdRO-00012D-F8 for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 19:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hkdRO-0008TH-9K for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 19:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2019 23:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25764-submit@debbugs.gnu.org id=B25764.156262993232505 (code B ref 25764); Mon, 08 Jul 2019 23:53:02 +0000 Original-Received: (at 25764) by debbugs.gnu.org; 8 Jul 2019 23:52:12 +0000 Original-Received: from localhost ([127.0.0.1]:59993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkdQZ-0008SD-ND for submit@debbugs.gnu.org; Mon, 08 Jul 2019 19:52:11 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:42818 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkdQY-0008Rw-5V for 25764@debbugs.gnu.org; Mon, 08 Jul 2019 19:52:10 -0400 Original-Received: from localhost (unknown [207.108.197.156]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id B8B3FFA02D; Mon, 8 Jul 2019 23:52:00 +0000 (UTC) In-Reply-To: <87o924l0l0.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 08 Jul 2019 21:42:51 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162409 Archived-At: "Basil L. Contovounesios" writes: > I don't use sieve scripts, but I noticed a minor nit in your patch: > > Eric Abrahamsen writes: > >> @@ -215,6 +214,7 @@ sieve-edit-script >> (sieve-mode) >> (setq sieve-buffer-script-name name) >> (goto-char (point-min)) >> + (set-buffer-modified-p nil) >> (message >> (substitute-command-keys >> "Press \\[sieve-upload] to upload script to server.")))) > > [...] > >> @@ -350,11 +350,13 @@ sieve-upload >> (with-current-buffer (get-buffer sieve-buffer) >> (setq err (sieve-manage-putscript >> (or name sieve-buffer-script-name (buffer-name)) >> - script sieve-manage-buffer)) >> - (if (sieve-manage-ok-p err) >> - (message (substitute-command-keys >> - "Sieve upload done. Use \\[sieve-manage] to manage scripts.")) >> - (message "Sieve upload failed: %s" (nth 2 err))))))) >> + script sieve-manage-buffer))) >> + (if (sieve-manage-ok-p err) >> + (progn >> + (message (substitute-command-keys >> + "Sieve upload done. Use \\[sieve-manage] to manage scripts.")) >> + (set-buffer-modified-p nil)) >> + (message "Sieve upload failed: %s" (nth 2 err)))))) > > In both hunks, 'message' is given an arbitrary string as its first > argument. Any objections to the following cleanup of sieve.el text > formatting code? I do use sieve! But I didn't write this code. Your proposed chances seem fine to me, though I'm wondering about the use of `ngettext' -- I saw some arguments on these lists recently about international/localization, and wasn't paying too much attention, but didn't see a clear resolution. Is it the consensus that we're supposed to be using `ngettext' where possible?