From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#17826: 24.4.50; compile.el: gcc-include is now all INFO, not WARNING Date: Sun, 04 Aug 2019 14:33:42 +0200 Message-ID: <87tvax9kk9.fsf@mouse.gnus.org> References: <87simy7ine.fsf@secretsauce.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193082"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 17826@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 04 15:15:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huGLy-000o4A-8t for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 15:15:14 +0200 Original-Received: from localhost ([::1]:44462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huGLx-000390-6I for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 09:15:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47960) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huGLp-00033n-6N for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huGLn-00076W-NT for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51986) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huGLn-00076Q-K8 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1huGLn-0000LM-EC for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2019 13:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17826 X-GNU-PR-Package: emacs Original-Received: via spool by 17826-submit@debbugs.gnu.org id=B17826.15649244801250 (code B ref 17826); Sun, 04 Aug 2019 13:15:03 +0000 Original-Received: (at 17826) by debbugs.gnu.org; 4 Aug 2019 13:14:40 +0000 Original-Received: from localhost ([127.0.0.1]:60804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huGLQ-0000K1-1y for submit@debbugs.gnu.org; Sun, 04 Aug 2019 09:14:40 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:37358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huGLJ-0000Hz-Lx for 17826@debbugs.gnu.org; Sun, 04 Aug 2019 09:14:34 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huFhn-0007LE-7p; Sun, 04 Aug 2019 14:33:45 +0200 In-Reply-To: <87simy7ine.fsf@secretsauce.net> (Dima Kogan's message of "Sat, 21 Jun 2014 01:48:21 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164565 Archived-At: Dima Kogan writes: > The attached patch changes the gcc-include type of "M-x compile" to be > INFO. Let's say I have 3 source files: > > a.c: > #include "a.h" > > a.h: > #include "b.h" > > b.h: > asdf; > > Clearly trying to compile a.c fails since b.h has an error. I do M-x > compile, and build with "gcc -c -o a.o a.c". I get a *compilation* > buffer with > > -*- mode: compilation; default-directory: "/tmp/" -*- > Compilation started at Sat Jun 21 01:43:01 > > gcc -c -o a.o a.c > In file included from a.h:1:0, > from a.c:1: > b.h:1:1: warning: data definition has no type or storage class [enabled by default] > aadsf; > ^ > > Compilation finished at Sat Jun 21 01:43:01 > > Prior to this patch the line that contains "from a.h:1:0," was seen as > INFO and the line that contains "from a.c:1:" was seen as a > WARNING. This patch makes them both INFO. I think this makes a lot of sense, and I've tried the patch, and it fixes this problem. Does anybody object to making both those "included" lines INFO instead of having one of them WARNING? (The practical effect here is that `next-error' will skip INFO lines by default.) > -\\([0-9]+\\)\\(?::\\([0-9]+\\)\\)?\\(?:\\(:\\)\\|\\(,\\|$\\)\\)?" > - 1 2 3 (4 . 5)) > +\\([0-9]+\\)\\(?::\\([0-9]+\\)\\)?\\(?:\\([:,]\\|$\\)\\)?" > + 1 2 3 (nil . 4)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no