From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#17052: substitute-command-keys strips text properties Date: Wed, 14 Aug 2019 18:58:57 -0700 Message-ID: <87tvaj6vfi.fsf@mouse.gnus.org> References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="268630"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Juanma Barranquero , 17052@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 15 04:00:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hy53k-0017hz-5q for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Aug 2019 04:00:12 +0200 Original-Received: from localhost ([::1]:37286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hy53i-0004Pv-G2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Aug 2019 22:00:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45433) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hy53b-0004PX-OW for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 22:00:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hy53a-0008Qx-PJ for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 22:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41275) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hy53a-0008Qn-Lx for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 22:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hy53a-0001Dh-GW for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 22:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Aug 2019 02:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17052 X-GNU-PR-Package: emacs Original-Received: via spool by 17052-submit@debbugs.gnu.org id=B17052.15658343454590 (code B ref 17052); Thu, 15 Aug 2019 02:00:02 +0000 Original-Received: (at 17052) by debbugs.gnu.org; 15 Aug 2019 01:59:05 +0000 Original-Received: from localhost ([127.0.0.1]:50096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hy52f-0001By-E4 for submit@debbugs.gnu.org; Wed, 14 Aug 2019 21:59:05 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:60624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hy52d-0001Bo-Hd for 17052@debbugs.gnu.org; Wed, 14 Aug 2019 21:59:03 -0400 Original-Received: from 24-104-73-23-ip-static.hfc.comcastbusiness.net ([24.104.73.23] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hy52Z-0006Vt-Jw; Thu, 15 Aug 2019 03:59:02 +0200 In-Reply-To: <1xh86jb494.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 14 Aug 2019 21:34:47 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165014 Archived-At: Glenn Morris writes: > Lars Ingebrigtsen wrote: > >> Looks like this has been fixed sometime in the intervening years? >> >> (substitute-command-keys (propertize "foo" 'face 'bold)) >> => #("foo" 0 3 (face bold)) > > Nope, you need to use an example which does a substitution, eg > > (substitute-command-keys (propertize "foo \\[find-file]" 'face 'bold)) Ah, I see. I've now reopened the bug report again. > The doc of substitute-command-keys used to mention this, but it was > somewhat prematurely removed in 049fac7. Heh, heh: (Fsubstitute_command_keys): Don't advertise the fact that text-properties are dropped, since we think it's a bug that we'll fix in 24.5. Should I just put it back in the doc string, or do we still think that we'll fix it? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no