From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Newsgroups: gmane.emacs.bugs Subject: bug#36981: 26.2; request: add searching by package name to list-packages Date: Sun, 08 Sep 2019 17:20:00 +0200 Message-ID: <87tv9mke73.fsf@gmail.com> References: <87ef0r396q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="125975"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36981@debbugs.gnu.org, ndame To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 08 17:21:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i6z03-000WdF-0N for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Sep 2019 17:21:11 +0200 Original-Received: from localhost ([::1]:49190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6z01-0008Pj-UK for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Sep 2019 11:21:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45266) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6yzv-0008PX-SQ for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 11:21:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i6yzu-0004aE-S5 for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 11:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i6yzu-0004a0-M8 for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 11:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i6yzu-0001AR-Ge for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 11:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Sep 2019 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36981 X-GNU-PR-Package: emacs Original-Received: via spool by 36981-submit@debbugs.gnu.org id=B36981.15679560104402 (code B ref 36981); Sun, 08 Sep 2019 15:21:02 +0000 Original-Received: (at 36981) by debbugs.gnu.org; 8 Sep 2019 15:20:10 +0000 Original-Received: from localhost ([127.0.0.1]:39040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6yz3-00018w-MB for submit@debbugs.gnu.org; Sun, 08 Sep 2019 11:20:09 -0400 Original-Received: from mail-wm1-f68.google.com ([209.85.128.68]:34738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6yz1-00018h-SH for 36981@debbugs.gnu.org; Sun, 08 Sep 2019 11:20:08 -0400 Original-Received: by mail-wm1-f68.google.com with SMTP id y135so10997092wmc.1 for <36981@debbugs.gnu.org>; Sun, 08 Sep 2019 08:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=NGi3BEx9D/7/4JMRmcE4vdJdL3H5M1vc42xPzZMVj6A=; b=urvvhIGJfThwqGIBFvH4Wmjfi9wz11ydqyv/P+93yD4e4tKx+U4ZeDr8CuzfEX7auc A1WxyJW2Bs0jXYdYqXFsogj3lyfdesRzI7TWsxezoIlczcu088SoAFFj8+OHt2i+xLKX bAJwIE70fVSgoH82RFtbr1gWZGkXsvl12A2zbpubElBGLRtauXaM2Kr72imdFXemZDXU 4C8GKecXtXQbiElA5KPIckMqEYjLg6A2OYNZ3RYX6KnT5ar/XBxn3nusFR7gA8lF7Ut0 eGPhvLratl3nmKpBnxWvfoVk2M4V+6i0dOoiLY+XMMLuPTxOqVBrsySYsjIXTIn41QK7 aF1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=NGi3BEx9D/7/4JMRmcE4vdJdL3H5M1vc42xPzZMVj6A=; b=H0CNUBROspUgzUnFLJ2i5qyoH53HcRkhyxClRrVoBoeO2dV9/ruVAYv/7KVJAD9al8 IXHo3iZWRBKO1cobkFM/eI/QBg3eAHxVfE5LNxje7UTy6J3qlAIHAuwnVE8kAay0Invj HhmdoxJ9FQuV1AtgdQ9yg1j6Qj3T0gf9x4p5aZ+5hyxYsPueQN5c5fDie1mH6Mdw9dgI ulR3/7vUXQbuo0DqhHGO1Re6UamBL7VXgE/uHtIqs38oHwdUPWj4EkfhQyS4rldq/Gas WEyDHHhl+h0ll1eUyL0O2FyLyf+7BDU/Bn8zsmH8zJvKzgiIS9mdmv+zoGzHnS+t+22X GKAA== X-Gm-Message-State: APjAAAUFdvdBoitZT92qL9H7OZbgMhMKt2DnYZJt5jEvCZyz8f/QqrKP ZrVMQ5QhCOcgzwVgXW4Ch1w= X-Google-Smtp-Source: APXvYqwcbvS5xy8JqfZ8akzU/sb8veVSoXXpWgYowtdq/qoksYaDjYMruWfU0kFCyW4/5c9U/zFxUQ== X-Received: by 2002:a1c:4384:: with SMTP id q126mr16663274wma.153.1567956002055; Sun, 08 Sep 2019 08:20:02 -0700 (PDT) Original-Received: from localhost ([185.112.167.114]) by smtp.gmail.com with ESMTPSA id k6sm24437954wrg.0.2019.09.08.08.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2019 08:20:01 -0700 (PDT) In-Reply-To: <87ef0r396q.fsf@gmail.com> (Federico Tedin's message of "Sun, 08 Sep 2019 02:47:57 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166302 Archived-At: I don't use package.el, but here are a few observations: > From: Federico Tedin > Date: Sun, 8 Sep 2019 02:38:43 +0200 > Subject: [PATCH 1/1] Search packages by name in list-packages (Bug#36981) > > + (if (or keywords (and packages (listp packages))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AKA "(consp packages)", though maybe you find your version more descriptive. > +(defun package-menu-search (name) > + "Filter the *Packages* buffer. > +Show only those items whose name matches NAME. If NAME is nil or an > +empty string, show all packages. If I was reading it as a user, I would appreciate it if the doc string was more specific regarding the NAME argument, e.g. said "matches the regular expression NAME" or something to that effect. Also, I think "empty string" is usually prefixed with "the", not "an", as there is only one such thing, e.g. (eq "" "") =3D> t.=20 > +To restore the full package list, type `q'." > + (interactive > + (list (read-from-minibuffer "Package name: ") > + current-prefix-arg)) ^^^^^^^^^^^^^^^^^^ Is this a remnant of some previous WIP version? The function now takes a single argument, right? Thanks! --=20 =C5=A0t=C4=9Bp=C3=A1n