From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: master 3fdc36e: Error out on --with-harfbuzz without HarfBuzz support Date: Mon, 18 Nov 2019 00:42:30 +0100 Message-ID: <87tv726peh.fsf@igel.home> References: <20191117180318.19632.60595@vcs0.savannah.gnu.org> <20191117180322.2A691209BF@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204135"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 18 00:43:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iWUCP-000qxJ-Am for ged-emacs-devel@m.gmane.org; Mon, 18 Nov 2019 00:43:21 +0100 Original-Received: from localhost ([::1]:57114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWUCO-0006mT-5A for ged-emacs-devel@m.gmane.org; Sun, 17 Nov 2019 18:43:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51416) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWUBo-0006iQ-8N for emacs-devel@gnu.org; Sun, 17 Nov 2019 18:42:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWUBk-0004XW-8T for emacs-devel@gnu.org; Sun, 17 Nov 2019 18:42:43 -0500 Original-Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]:43370) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iWUBk-0004Wl-2k for emacs-devel@gnu.org; Sun, 17 Nov 2019 18:42:40 -0500 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 47GTCc4Y0Pz1rGRn; Mon, 18 Nov 2019 00:42:36 +0100 (CET) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 47GTCc3Z1Vz1qqtR; Mon, 18 Nov 2019 00:42:36 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id h_LtuVTyZlCa; Mon, 18 Nov 2019 00:42:31 +0100 (CET) X-Auth-Info: Zc4OnMqXJUvrxE8589FpdTLdXD8pb1nvtssW9BNzNAnpoVFmzS1jQrp7ZXiYFoEY Original-Received: from igel.home (ppp-46-244-181-133.dynamic.mnet-online.de [46.244.181.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 18 Nov 2019 00:42:31 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 1000) id 9503A2C0B74; Mon, 18 Nov 2019 00:42:30 +0100 (CET) X-Yow: ..I'll make you an ASHTRAY!! In-Reply-To: <20191117180322.2A691209BF@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 17 Nov 2019 13:03:19 -0500 (EST)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:a60:0:28:0:1:25:1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242340 Archived-At: On Nov 17 2019, Lars Ingebrigtsen wrote: > diff --git a/configure.ac b/configure.ac > index 3b6a2a6..0976b66 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -3469,6 +3469,11 @@ if test "${HAVE_X11}" = "yes" && test "${HAVE_FREETYPE}" = "yes" \ > fi > fi > > +# The user explicitly asked for HarfBuzz, but it won't be used. > +if test "${with_harfbuzz}" == "yes" && test "$HAVE_HARFBUZZ" != "yes"; then > + AC_MSG_ERROR([HarfBuzz wanted, but won't be used. Maybe some library files are missing?]); > +fi That gives a spurious error when configuring with --without-x. Also, test a == b is a bashism. The string compare operator is =. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."