From: Andreas Schwab <schwab@linux-m68k.org>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master 3fdc36e: Error out on --with-harfbuzz without HarfBuzz support
Date: Mon, 18 Nov 2019 00:42:30 +0100 [thread overview]
Message-ID: <87tv726peh.fsf@igel.home> (raw)
In-Reply-To: <20191117180322.2A691209BF@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 17 Nov 2019 13:03:19 -0500 (EST)")
On Nov 17 2019, Lars Ingebrigtsen wrote:
> diff --git a/configure.ac b/configure.ac
> index 3b6a2a6..0976b66 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3469,6 +3469,11 @@ if test "${HAVE_X11}" = "yes" && test "${HAVE_FREETYPE}" = "yes" \
> fi
> fi
>
> +# The user explicitly asked for HarfBuzz, but it won't be used.
> +if test "${with_harfbuzz}" == "yes" && test "$HAVE_HARFBUZZ" != "yes"; then
> + AC_MSG_ERROR([HarfBuzz wanted, but won't be used. Maybe some library files are missing?]);
> +fi
That gives a spurious error when configuring with --without-x.
Also, test a == b is a bashism. The string compare operator is =.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next parent reply other threads:[~2019-11-17 23:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191117180318.19632.60595@vcs0.savannah.gnu.org>
[not found] ` <20191117180322.2A691209BF@vcs0.savannah.gnu.org>
2019-11-17 23:42 ` Andreas Schwab [this message]
2019-11-18 8:51 ` master 3fdc36e: Error out on --with-harfbuzz without HarfBuzz support Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv726peh.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.