From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#21563: 24.5; discourage load-hook variables Date: Wed, 15 Jan 2020 20:32:12 +0100 Message-ID: <87tv4w1poj.fsf@marxist.se> References: <39185.7955.374134.22021@gargle.gargle.HOWL> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="93805"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 21563@debbugs.gnu.org To: "Roland Winkler" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 15 20:33:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iroPu-000OH8-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 20:33:26 +0100 Original-Received: from localhost ([::1]:59584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iroPs-0002TI-QT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 14:33:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37838) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iroPa-0002Qn-25 for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 14:33:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iroPW-0002Vg-9l for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 14:33:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57844) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iroPW-0002VW-5I for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 14:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iroPW-00082V-1P for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 14:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jan 2020 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21563 X-GNU-PR-Package: emacs Original-Received: via spool by 21563-submit@debbugs.gnu.org id=B21563.157911674829933 (code B ref 21563); Wed, 15 Jan 2020 19:33:01 +0000 Original-Received: (at 21563) by debbugs.gnu.org; 15 Jan 2020 19:32:28 +0000 Original-Received: from localhost ([127.0.0.1]:35584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iroOu-0007jn-Nn for submit@debbugs.gnu.org; Wed, 15 Jan 2020 14:32:28 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:36250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iroOq-0007cx-1u for 21563@debbugs.gnu.org; Wed, 15 Jan 2020 14:32:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nRKQUPJbr8e02+pieSg0yoXkGjMtMttkfR9Vnj+OWx4=; b=NIezu5nLaGRAB7bgXi4goc0Bby j+tlS+khg2L+leqhr5seSpeChCw7X6nyHXqYcwNTGxjf8hp/kYqjaQtAqOgoHhK+M3QoZ9SiRUW4f XTUrP9IYFnJbiJw1RnKw0Q8X2iaijBDYM+PkmcMNfwsAcdyCEuuxT9Xl08dgN0wTQpmENl0piHzpq HRHAMwZZQO5T2602/7DMh4AwxNU/CgX3SNeCdFgsalYTUy1VO30UibJSBfa7dBAMbh5mhqSb1sYRW DGULjgnxeeWElagnlqCgN2+cqL/uEzHYol6wOneJnl47o4B6zakCzlo3pIy2H01g3Kmq45F+G6Lwy Cw8pce6w==; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:46792 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iroOk-001lro-Cf; Wed, 15 Jan 2020 14:32:14 -0500 In-Reply-To: <39185.7955.374134.22021@gargle.gargle.HOWL> (Roland Winkler's message of "Fri, 25 Sep 2015 13:57:21 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174654 Archived-At: "Roland Winkler" writes: > Somewhere in my emacs init file I was setting the variable > dired-load-hook. (I guess I wrote this code years ago when I did > not know much about emacs.) Yet suddenly this did not work for me > anymore, as I had rearranged my init file so that dired got loaded > before I was setting dired-load-hook. I suggest to discourage the > usage of any such load-hook variables: I believe eval-after-load is > considered to be the cleaner alternative: it does not give rise to > the type of problems I ran into. Also it does not require user > variables for each package. > > (Apropos gives me the variables align-load-hook, cal-menu-load-hook, > calendar-load-hook, dired-load-hook, ediff-load-hook, and > table-load-hook. There might be more.) This suggests that all such variables should be considered obsolete, since eval-after-load is cleaner. I think I agree, but I have only ever used eval-after-load so I might be missing something. I would suggest to declare the above variables obsolete and point users to eval-after-load instead. Does anyone disagree with that? Best regards, Stefan Kangas