From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.bugs Subject: bug#39596: 26.3; Export INSIDE_EMACS with Eshell Date: Wed, 19 Feb 2020 22:16:05 +0100 Message-ID: <87tv3ml1m2.fsf@gmail.com> References: <87a75lvds8.fsf@ambrevar.xyz> <87blpvc9ek.fsf@ambrevar.xyz> <87y2sylf7p.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="116233"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: Pierre Neidhardt , 39596@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 19 22:17:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4WiV-000U6E-3G for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 22:17:11 +0100 Original-Received: from localhost ([::1]:60470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4WiU-0003n8-2O for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 16:17:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56396) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4WiM-0003my-TA for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 16:17:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4WiL-0006U5-VD for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 16:17:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37479) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4WiL-0006Tz-QO for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 16:17:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4WiL-0004IK-Mj for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 16:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Federico Tedin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Feb 2020 21:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39596 X-GNU-PR-Package: emacs Original-Received: via spool by 39596-submit@debbugs.gnu.org id=B39596.158214697516443 (code B ref 39596); Wed, 19 Feb 2020 21:17:01 +0000 Original-Received: (at 39596) by debbugs.gnu.org; 19 Feb 2020 21:16:15 +0000 Original-Received: from localhost ([127.0.0.1]:43452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4Wha-0004H9-V2 for submit@debbugs.gnu.org; Wed, 19 Feb 2020 16:16:15 -0500 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:37785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4WhZ-0004Gv-5x for 39596@debbugs.gnu.org; Wed, 19 Feb 2020 16:16:13 -0500 Original-Received: by mail-wm1-f47.google.com with SMTP id a6so2237354wme.2 for <39596@debbugs.gnu.org>; Wed, 19 Feb 2020 13:16:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MokwXsZYdY3a6GPSfTLHagkV86Cio2nEefBD/ibBJ/g=; b=lb57pdX2oRougQb7NZHtTaykEqQqAa4ONkQOfJuwJOnWzMiJJHOHIL5bn4LyH5Xgas ont0a4UIOzCwMKnWnUH1JjRKRgXYtfYnDopQJl23lHjNGsa9YcwMmko77X5bAaB//aW/ k5eD0xwqEQMb3SLs+39Jy8nCGM+TUpwtyuK/zoQqygRPVAto7YDaWafp5aHEceDPl2tf uZA8775PRtmEg2RqitY1XXVM+T1eBCx4nbdv/QKQYsrDO0xJ0hjyV9wbhQPxw7ye2nCN u615peg6UCAMC0AJdtEpfc9lxN+4d4jBoYY8KLbZMyTS5Z54NbFKBpatVNJtGnMDk3vP FagQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MokwXsZYdY3a6GPSfTLHagkV86Cio2nEefBD/ibBJ/g=; b=k5fFqpF5FxrtS9G1gzGzKctHb66mc0J12zci/7iysizwrHtbCPFjrCEMy0/Fvdz0He Ge0fis22qmGIUXId/E9J6gvHnr5bvY97qqfXZs00AKxxsrj0/3DOwc9Mqv9Zpz263zM0 P6EiZN/Kjh3KuNLUv83NKRaW2tmrseHITxxfO8kesiVmTjVZZrqCA21kOaL3lgICRoyE K+VAlzX53tYvSMUQ/vq6vvKj8gMfWaPLeat+vJegFPWaqgUua/bVwGFMV7bu9v5uYLBn mwCawKck9PLd2nQPYam2BJxHMS7e6asK7idyRknHtT3UdbkGmH7dnLOdCA1xG64VQ0vQ m7Bw== X-Gm-Message-State: APjAAAVjuxRm8pOx85nu2Kw9TcVeBy6X4nMgHu8MD1LCsLaMLwQ6v0HR Kxj01is44T+TVsUenmKsheQZ7m3kOv4= X-Google-Smtp-Source: APXvYqzwttEJ+ED4tqFkMcS6p2VMPu6kJVRgSyFBMEhoBwmlMGgZrCaC4Wwf9gFcmZGBdmbITkZnJQ== X-Received: by 2002:a1c:7419:: with SMTP id p25mr4643105wmc.159.1582146966972; Wed, 19 Feb 2020 13:16:06 -0800 (PST) Original-Received: from lead ([2a02:8109:8ac0:2ff0:8cca:6d1d:698e:b77]) by smtp.gmail.com with ESMTPSA id q9sm1406832wrx.18.2020.02.19.13.16.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Feb 2020 13:16:06 -0800 (PST) In-Reply-To: (Andreas Schwab's message of "Wed, 19 Feb 2020 18:10:06 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176261 Archived-At: Andreas Schwab writes: > On Feb 19 2020, Federico Tedin wrote: > >> Pierre Neidhardt writes: >> >>> Thanks for looking at this, Federico! >>> >>> Your patch looks good to me, just one comment below: >>> >>>> --- a/lisp/eshell/em-dirs.el >>>> +++ b/lisp/eshell/em-dirs.el >>>> @@ -191,6 +191,9 @@ eshell-dirs-initialize >>>> (unless (ring-empty-p eshell-last-dir-ring) >>>> (expand-file-name >>>> (ring-ref eshell-last-dir-ring 0)))) >>>> + t) >>>> + ("INSIDE_EMACS" ,(lambda (_indices) >>>> + (format "%s,eshell" emacs-version)) >>>> t)))) >>> >>> Why did you unquote the lambda here? >> >> I need to unquote the lambda to get its value, right? > > Unquoting allows it to be byte-compiled. > > Andreas. Wasn't aware of that, thanks.