all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Federico Tedin <federicotedin@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Pierre Neidhardt <mail@ambrevar.xyz>, 39596@debbugs.gnu.org
Subject: bug#39596: 26.3; Export INSIDE_EMACS with Eshell
Date: Wed, 19 Feb 2020 22:16:05 +0100	[thread overview]
Message-ID: <87tv3ml1m2.fsf@gmail.com> (raw)
In-Reply-To: <mvmftf61p1t.fsf@suse.de> (Andreas Schwab's message of "Wed, 19 Feb 2020 18:10:06 +0100")

Andreas Schwab <schwab@suse.de> writes:

> On Feb 19 2020, Federico Tedin wrote:
>
>> Pierre Neidhardt <mail@ambrevar.xyz> writes:
>>
>>> Thanks for looking at this, Federico!
>>>
>>> Your patch looks good to me, just one comment below:
>>>
>>>> --- a/lisp/eshell/em-dirs.el
>>>> +++ b/lisp/eshell/em-dirs.el
>>>> @@ -191,6 +191,9 @@ eshell-dirs-initialize
>>>>  		        (unless (ring-empty-p eshell-last-dir-ring)
>>>>  			  (expand-file-name
>>>>  			   (ring-ref eshell-last-dir-ring 0))))
>>>> +            t)
>>>> +           ("INSIDE_EMACS" ,(lambda (_indices)
>>>> +                              (format "%s,eshell" emacs-version))
>>>>              t))))
>>>
>>> Why did you unquote the lambda here?
>>
>> I need to unquote the lambda to get its value, right?
>
> Unquoting allows it to be byte-compiled.
>
> Andreas.

Wasn't aware of that, thanks.





      reply	other threads:[~2020-02-19 21:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  7:17 bug#39596: 26.3; Export INSIDE_EMACS with Eshell Pierre Neidhardt
2020-02-18 23:18 ` Federico Tedin
2020-02-19  7:40   ` Pierre Neidhardt
2020-02-19 16:22     ` Federico Tedin
2020-02-19 16:30       ` Pierre Neidhardt
2020-02-19 17:10       ` Andreas Schwab
2020-02-19 21:16         ` Federico Tedin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tv3ml1m2.fsf@gmail.com \
    --to=federicotedin@gmail.com \
    --cc=39596@debbugs.gnu.org \
    --cc=mail@ambrevar.xyz \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.