From: Amin Bandali <bandali@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window
Date: Tue, 14 Apr 2020 11:59:10 -0400 [thread overview]
Message-ID: <87tv1m6ott.fsf@gnu.org> (raw)
In-Reply-To: <831roqhxvt.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Amin Bandali <bandali@gnu.org>
>> Cc: emacs-devel@gnu.org
>> Date: Tue, 14 Apr 2020 11:12:34 -0400
>>
>> I think the changes are simple yet useful enough to be in emacs-27;
>> though in hindsight, the master branch may have been a better place for
>> them. That said, if you or others spot any issues with them, I'd be
>> more than happy to try and address them, or even revert them if needed.
>
> The danger is that we release Emacs 27.1 with some problem caused by
> these changes undetected. But if you think this danger is small, I
> guess I'm okay with that.
>
> Thanks.
>
Makes sense. In this specific case, I really do think the danger is
small, as I didn't make any changes to the implementation logic for
either of the two original functions, and the two new functions only
differ from the original ones in using `switch-to-buffer-other-window'.
That said if there is anything unclear or suspicious-looking about my
changes, please let me know and I will revert them and apply them to
master instead.
Thanks,
amin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
prev parent reply other threads:[~2020-04-14 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 5:28 [Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window Eli Zaretskii
2020-04-14 15:12 ` Amin Bandali
2020-04-14 15:48 ` Eli Zaretskii
2020-04-14 15:59 ` Amin Bandali [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv1m6ott.fsf@gnu.org \
--to=bandali@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.