From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: eww and bookmarks Date: Mon, 08 Jun 2020 16:42:36 +0200 Message-ID: <87tuzlwrdv.fsf@web.de> References: <87k1163jz5.fsf@gmail.com> <87tv0a5k5b.fsf@web.de> <87mu5ec3pf.fsf@web.de> <87mu5e3ncg.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="43676"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 08 16:48:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiJ4S-000BI3-Gs for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Jun 2020 16:48:16 +0200 Original-Received: from localhost ([::1]:59654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiJ4R-0003pt-A4 for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Jun 2020 10:48:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiIz4-0000Au-IW for emacs-devel@gnu.org; Mon, 08 Jun 2020 10:42:42 -0400 Original-Received: from mout.web.de ([212.227.15.14]:41031) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiIz3-0008MU-8v for emacs-devel@gnu.org; Mon, 08 Jun 2020 10:42:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1591627357; bh=EfaAGYRxryF9pIm4d0IRa7lnd37J08Q+/Ex76hRbnbg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=lL6SxtaUZxwWL2BMnJFsYM8PD/WwlvLVdSFI7zNG6tWtLzP0aj5wNa9Dt4fjdktJR Fu/XaqJOKTnNt5FtZRJe5tm35SBidX9oWMJTyYxkUhCQYIh2KxloG5ksNdFKqpQJsR 6xIp/c3rsbDlq0H81AXFTi/jpNdXSDsZcTrZkpbI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.217.119.187]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MNtP9-1jbRDi15XH-007WWp; Mon, 08 Jun 2020 16:42:37 +0200 In-Reply-To: <87mu5e3ncg.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 07 Jun 2020 16:30:23 +0100") X-Provags-ID: V03:K1:qcEkXb+iAcD2KYupOk2buZKlFfXSQ9gHbDlX5J2rp6IOzBZUyDZ 5YgnhiMOgo5igOtIVwuH/9NSzgOYgTAVnRPpjDT9b1+o2H+lb2bg6IUvUdH5wNfl9SSwsK2 bDdWzDVmkVmg3gSHTPJHh+Hw2HH3dH79PoPmO2/vbTFUt7f60Q6QC/B0M5Cz9/qlP3lisyO 32wxLm8FkmGSqLHJQ2n9g== X-UI-Out-Filterresults: notjunk:1;V03:K0:NGtVQM2a3xQ=:6KeYLQ87yzeP7WLztpyJWN WMHWIEQ7oxOXvyhMB81820pFRyFlW1eGXfMBUr0vkggX/38di+c9cD3L5hH0K/jaXV/Pf4h6+ tgtL0xjNO707jeDcVUXkJi55Ol9wAjETvwWkNgaq3FY64Psp9T7dZ1eaxuLqt7b4ER8vYWZ3e YJk5WKHDPql43Mwd46Znyuipx42dUUrQF/ok9zlf2DUgHynG+y/r+znZ7f6vabPyBke0G+GQY Z8t6DahK333FETcCNNx2WDmm6vQ+J1SVUPKM0nk8W3D2WwMzgTtCOyHRyZtKbN3ocFjTa7jZ7 OvhDNinIcvUGAt6TRgGAI8k7LJfYma6Q2Kti2cFIHEPmEPbcr4vGTEAK+7afRbqlGwLOQmUag y2XOfxH/3dNXvoO58aUt2EeSLWOvRIK6MuvCna2HHnfzYIM/48RNrcuTZeMHeIn8J2cD/Kwa2 Ff8eFYK7+MMDZCV9vxVrgyRNCFZt7jWTkggVKQX+749ovI30G3fdb/mTnrIt4YmFRsjbJ3Y0D Cwkhq/KuMR6NIYx7rLeHICxiTfiktOmnKo4UFlbJNMJo7QKibhdocSsCoGYnJSE/OD1WF+IPM r28a2hpDJkEQZsc5v9DkoYd8SsetfsSBrcDd1/Uho0fIJBp/Owl7vDgtwB+L7MmeJ9WF68f7I 7QFGmb5RIeY9AH4DFTp0HUntSsTqCJREzfLZl55WPQJXL3b5SeoSKEESRTH0InzP3WSnemjzk VRRZ/Ox3aVbd7mF628dyQnbfJ3LZLbzOUcFgEkeemg9SchVpdRabQxwoY3MlXTBK72OZQ6jZ Received-SPF: pass client-ip=212.227.15.14; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 10:42:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252044 Archived-At: "Basil L. Contovounesios" writes: > > +(defcustom bookmark-eww-browse-url-function #'eww-browse-url > > + "Doc..." > > + :type '(choice > > + (function-item eww-browse-url :doc "Use eww") > > + (const :tag "Use value of `browse-url-browser-function'" ni= l) > > + function)) > > Isn't it strange having a boookmark-... variable defined in eww.el? Yes. OTOH I wanted to avoid the risk of confusion with eww bookmarks and not call it "eww-bookmark-...". Suggestions? > > +(defun eww--bookmark-title (title-string) > > + (replace-regexp-in-string > > + "\\` +\\| +\\'" "" > > + (replace-regexp-in-string "[\n\t\r]" " " title-string))) > > Is the outer replace-regexp-in-string doing the same as string-trim? Is it? I didn't touch that code, I only moved it for factoring. > > +(defun eww-bookmark-make-record () > > + "Create an emacs bookmark record > ^^^^^ > Capitalize Done. > > for an eww buffer. > > ^^^ > > Upcase Is it ok to leave it downcased? Thanks, Michael.