From: "Philip K." <philip@warpmail.net>
To: Juri Linkov <juri@linkov.net>
Subject: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el
Date: Wed, 17 Jun 2020 12:51:07 +0200 [thread overview]
Message-ID: <87tuzaotic.fsf@warpmail.net> (raw)
In-Reply-To: <87v9jqfzbv.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 17 Jun 2020 00:57:56 +0300")
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
Juri Linkov <juri@linkov.net> writes:
> I think your choice of keys is better than in project-switch-commands.
> Maybe these keys should be copied to project-switch-commands, so it will to be
> in sync with project-prefix-map?
>
> Or is it possible to use project-prefix-map directly in project-switch-commands?
> For example, by using set-transient-map?
I tried implementig it, and it seems to work. The patch below isn't a
full commit, since I changed the structure of project-switch-commands
(it's now mapping command to description), but didn't update the
docstring.
--
Philip K.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff, Size: 2111 bytes --]
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index c5301dccd3..6cb9811d3d 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -860,12 +879,12 @@ project-prompt-project-dir
;;;###autoload
(defvar project-switch-commands
- '((?f "Find file" project-find-file)
- (?r "Find regexp" project-find-regexp)
- (?d "Dired" project-dired)
- (?v "VC-Dir" project-vc-dir)
- (?s "Shell" project-shell)
- (?e "Eshell" project-eshell))
+ '((project-find-file "Find file")
+ (project-find-regexp "Find regexp")
+ (project-dired "Dired")
+ (project-vc-dir "VC-Dir")
+ (project-shell "Shell")
+ (project-eshell "Eshell"))
"Alist mapping keys to project switching menu entries.
Used by `project-switch-project' to construct a dispatch menu of
commands available upon \"switching\" to another project.
@@ -877,9 +896,10 @@ project-switch-commands
(defun project--keymap-prompt ()
"Return a prompt for the project swithing dispatch menu."
(mapconcat
- (pcase-lambda (`(,key ,label))
+ (pcase-lambda (`(,cmd ,label))
(format "[%s] %s"
- (propertize (key-description `(,key)) 'face 'bold)
+ (propertize (key-description (where-is-internal cmd project-prefix-map t))
+ 'face 'bold)
label))
project-switch-commands
" "))
@@ -890,14 +910,10 @@ project-switch-project
The available commands are picked from `project-switch-commands'
and presented in a dispatch menu."
(interactive)
- (let ((dir (project-prompt-project-dir))
- (choice nil))
- (while (not choice)
- (setq choice (assq (read-event (project--keymap-prompt))
- project-switch-commands)))
- (let ((default-directory dir)
- (project-current-inhibit-prompt t))
- (call-interactively (nth 2 choice)))))
+ (let ((default-directory (project-prompt-project-dir))
+ (project-current-inhibit-prompt t))
+ (message "%s" (project--keymap-prompt))
+ (set-transient-map project-prefix-map)))
(provide 'project)
;;; project.el ends here
next prev parent reply other threads:[~2020-06-17 10:51 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 9:49 bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Theodor Thornhill
[not found] ` <83pn9z13xq.fsf@gnu.org>
2020-06-16 16:44 ` Theodor Thornhill
2020-06-16 17:16 ` Eli Zaretskii
2020-06-16 17:30 ` Theodor Thornhill
2020-06-16 18:14 ` Basil L. Contovounesios
2020-06-16 19:07 ` Theodor Thornhill
2020-06-16 19:12 ` Theodor Thornhill
2020-06-16 21:57 ` Juri Linkov
2020-06-16 22:47 ` Dmitry Gutov
2020-06-16 23:24 ` Juri Linkov
2020-06-16 23:42 ` Dmitry Gutov
2020-06-17 21:23 ` Juri Linkov
2020-06-17 22:16 ` Dmitry Gutov
2020-06-17 22:27 ` Juri Linkov
2020-06-17 22:38 ` Dmitry Gutov
2020-06-17 23:23 ` Juri Linkov
2020-06-17 23:36 ` Dmitry Gutov
2020-06-18 22:59 ` Juri Linkov
2020-06-18 23:08 ` Dmitry Gutov
2020-06-20 23:41 ` Juri Linkov
2020-06-21 0:25 ` Dmitry Gutov
2020-06-17 10:51 ` Philip K. [this message]
2020-06-16 20:31 ` Basil L. Contovounesios
2020-06-17 19:10 ` Theodor Thornhill
2020-06-17 19:40 ` Basil L. Contovounesios
2020-06-17 23:07 ` Dmitry Gutov
2020-06-16 21:23 ` Dmitry Gutov
2020-06-16 21:35 ` Dmitry Gutov
2020-06-17 14:28 ` Eli Zaretskii
2020-06-17 14:27 ` Eli Zaretskii
2020-06-17 15:49 ` Dmitry Gutov
2020-06-17 16:33 ` Eli Zaretskii
2020-06-17 22:23 ` Dmitry Gutov
2020-06-18 13:38 ` Eli Zaretskii
2020-06-18 15:47 ` Dmitry Gutov
2020-06-18 17:24 ` Eli Zaretskii
2020-06-18 18:18 ` Michael Albinus
2020-06-18 16:25 ` Stefan Monnier
2020-06-18 17:30 ` Eli Zaretskii
2020-06-18 18:22 ` Dmitry Gutov
2020-06-18 18:42 ` Eli Zaretskii
2020-06-18 18:54 ` Dmitry Gutov
2020-06-18 19:04 ` Eli Zaretskii
2020-06-18 21:12 ` Dmitry Gutov
2020-06-19 6:11 ` Eli Zaretskii
[not found] ` <3ad1ecbb-36d6-79c0-7a7b-6ff3a561e512@yandex.ru>
2020-06-18 14:09 ` Philip K.
2020-06-18 17:22 ` Basil L. Contovounesios
2020-06-18 18:50 ` Philip K.
2020-06-18 22:10 ` Juri Linkov
2020-06-18 23:01 ` Dmitry Gutov
2020-06-18 23:24 ` Juri Linkov
2020-06-18 23:31 ` Dmitry Gutov
2020-06-19 10:15 ` Simen Heggestøyl
2020-07-11 17:07 ` Sean Whitton
2020-07-12 15:18 ` Dmitry Gutov
2020-07-12 16:24 ` Sean Whitton
2020-07-12 20:12 ` Dmitry Gutov
2020-07-18 16:06 ` bug#42210: " Sean Whitton
2020-07-19 23:46 ` Dmitry Gutov
2020-07-20 0:30 ` Juri Linkov
2020-07-20 1:04 ` bug#41890: " Dmitry Gutov
2020-07-20 20:47 ` Juri Linkov
2020-07-20 21:00 ` Dmitry Gutov
2020-07-20 16:49 ` Sean Whitton
2020-07-20 20:41 ` bug#41890: " Juri Linkov
2020-07-20 21:02 ` Dmitry Gutov
2020-07-20 21:24 ` bug#41890: " Sean Whitton
2020-07-20 22:00 ` Dmitry Gutov
2020-07-21 0:33 ` Sean Whitton
2020-07-21 23:38 ` Juri Linkov
2020-07-22 0:38 ` Dmitry Gutov
2020-07-22 1:33 ` Sean Whitton
2020-07-22 19:28 ` bug#41890: " Sean Whitton
2020-07-23 23:46 ` Dmitry Gutov
2020-07-24 2:04 ` Sean Whitton
2020-07-24 6:01 ` bug#41890: " Eli Zaretskii
2020-07-24 15:12 ` Sean Whitton
2020-07-24 16:12 ` Eli Zaretskii
2020-07-24 21:20 ` Sean Whitton
2020-07-24 22:54 ` Dmitry Gutov
2020-07-24 23:13 ` Sean Whitton
2020-07-24 23:45 ` Dmitry Gutov
2020-07-25 6:14 ` Eli Zaretskii
2020-07-26 5:15 ` bug#41890: " Sean Whitton
2020-07-27 0:01 ` Dmitry Gutov
2020-07-22 1:31 ` Sean Whitton
2020-07-23 0:32 ` bug#41890: " Juri Linkov
2020-07-23 15:06 ` Sean Whitton
2020-07-20 10:21 ` Basil L. Contovounesios
2020-07-20 14:45 ` Eli Zaretskii
2020-07-12 23:48 ` Juri Linkov
2020-07-13 0:13 ` Dmitry Gutov
2020-07-13 0:23 ` Juri Linkov
2020-07-13 6:56 ` Philip K.
2020-07-13 10:47 ` Dmitry Gutov
2020-07-13 10:50 ` Dmitry Gutov
2020-07-13 11:02 ` Philip K.
2020-07-18 15:19 ` Sean Whitton
2020-07-13 23:49 ` Juri Linkov
2020-07-14 7:03 ` Philip K.
2020-07-14 22:34 ` Juri Linkov
2020-07-14 23:32 ` Dmitry Gutov
2020-07-15 23:59 ` Juri Linkov
2020-07-16 13:38 ` Dmitry Gutov
2020-07-15 19:21 ` Philip K.
2020-07-15 23:35 ` Dmitry Gutov
[not found] ` <902001d0-ab1c-b697-bfd0-b8ec195dc65f@yandex.ru>
2020-06-19 10:13 ` Simen Heggestøyl
2020-06-19 10:26 ` Philip K.
2020-06-19 10:50 ` Simen Heggestøyl
2020-06-19 12:25 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuzaotic.fsf@warpmail.net \
--to=philip@warpmail.net \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.