From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#42237: [PATCH] Clean up Tramp version check Date: Sun, 12 Jul 2020 15:48:40 +0200 Message-ID: <87tuyczvwn.fsf__38039.3749148183$1594561783$gmane$org@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31221"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42237@debbugs.gnu.org, tramp-devel@gnu.org To: Nicholas Drozd Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 12 15:49:39 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jucMM-00083U-Um for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Jul 2020 15:49:38 +0200 Original-Received: from localhost ([::1]:56452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jucML-0005K6-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Jul 2020 09:49:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jucLm-0005JZ-12 for bug-gnu-emacs@gnu.org; Sun, 12 Jul 2020 09:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jucLl-0003lw-NS for bug-gnu-emacs@gnu.org; Sun, 12 Jul 2020 09:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jucLl-0005js-Kt for bug-gnu-emacs@gnu.org; Sun, 12 Jul 2020 09:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Jul 2020 13:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42237-submit@debbugs.gnu.org id=B42237.159456173222044 (code B ref 42237); Sun, 12 Jul 2020 13:49:01 +0000 Original-Received: (at 42237) by debbugs.gnu.org; 12 Jul 2020 13:48:52 +0000 Original-Received: from localhost ([127.0.0.1]:45592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jucLb-0005jU-AZ for submit@debbugs.gnu.org; Sun, 12 Jul 2020 09:48:51 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:57621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jucLY-0005jE-8z for 42237@debbugs.gnu.org; Sun, 12 Jul 2020 09:48:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1594561721; bh=LAKZ9BFFlu0SXQJq40wxYXKH+igR95AdchiOR3OkeSc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=OVAF1hG6OQtVMIN6hmGuvAuZP2qhjeskVa9WHmx9Y0wLzpgDO1ijJnfW/7aPGIN3L m4ceSyffOuVBsWWnmRJmYRbiTAvC7umbg9XoExyqROEb/Efr8nTp/o4A1PSqyxs7Ad OhSnY6NL/B5Lc03bdTskeDVa6ywPnCVqmMNQ9r8c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.47.60]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M1poA-1jsQU51j5c-002Gna; Sun, 12 Jul 2020 15:48:41 +0200 In-Reply-To: (Nicholas Drozd's message of "Sat, 11 Jul 2020 12:12:19 -0500") X-Provags-ID: V03:K1:ReDXtU6aeUuaUyRuQvBJ4CFg/B90NuHExk4RyGzg3IC0dU2iYOq DCEZL962Vu9TFv5QyuNrcfIurLhbArZoXHBS3rtek4WT5dhk3Zn6s6TZ0pawylNtuYprCDW FhYH1wQgHT4WKx2/fDfIbdRw/qKEM81T8BXd9Q2tWl++RMMhYnGcLWPYot9E4m7BmNSdvi3 H60MRmtai64sDzBPn4Iiw== X-UI-Out-Filterresults: notjunk:1;V03:K0:ekz5aguNIDA=:h5+4CN1v0ihNI3dobPqpRz FDI+R0EltxRUFZ1a+rOdSN4PycJBgiJNxHzle5xUR7siXi6SLL+eQFfQXCgQV7/adjrUt7RKZ 7ZozwSMlECc8SvqMPxUp9Bv5LVuUPhT40JWDSEqmsnal0rOgC/7mhR2pa6rcsx2fwhBAuYIXR edzpZ+sDDGCRWdsqEoQhbVICm4UYsOCDBMFZlyCMydJfajC5R4EOUykS058kMbhTFVAXbOJ1J qUyiY7He7quSrw6d6zDGa9RTVGMijNnaHr2pgyzrDjBamxwY+uwFXDiIqBqjrRnXUHOlzqXsO sM6CrGNuSoSxCtHPjIe4ip55y5ILNkRl7CmU6nEUVsBUWCYCvV7wQPygXv+MxillBN297ItN1 4Kmh6Xv7JStgFKLvRcT2vscxzMB3lZ82Sib1kvJgd8z4HePNLP+vOOZreTmuojUfqGi+oRhqE Hy+zF0PTsxec/Md8+jCHyStyuMCaHWodQq9/xzPns5WfFaXkXO8h88w+uRxbBZ0NXKr9QuUyy N4kJ4q09B5s4tZK4vLL0fV7xmnYnxh+/I7Poy/lnSRTUH6bLob3W5+wcH33jGQThhaDM7hzEA oh44YeKqioIuqtHKfJ6EjK8/plrsHaJlU0oymiTyUwzuEynuwaiTgjsqLCi7+w5ibs7iM8rzj vGwg0cJPC0Tezg+gl2loeamAVqeaEPag//OaYX8FM0FN9qivUrOccfza9rh3XNqkEbwg8ZZfX 1EnvGM5yMnoKNZvGkCsCDBEctEAr7IAvcWKhCzf6w0l+vHfhckbISTwopKsq1NF7pjFOvz0M X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182943 Archived-At: Nicholas Drozd writes: Hi Nicholas, > This turned out to be quite a piece of code indeed. I think this > change respects all the existing requirements. As I said before, this > shouldn't change any behavior, apart from adding the new function and > variable. Feel free to reject. Thanks. However, > + (let ((tramp-minimum-emacs-version "30.1")) > + (should-error (tramp-check-version)))) this does not work as expected. What is this check good for? I understand your intention, but do we need to test this case? Best regards, Michael.