From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: A question about overlays and performance. Date: Fri, 31 Jul 2020 02:04:45 +0300 Organization: LINKOV.NET Message-ID: <87tuxobo4y.fsf@mail.linkov.net> References: <835zabcz8d.fsf@gnu.org> <87365foyam.fsf@localhost> <87tuxttda9.fsf@localhost> <87wo2ncg7j.fsf@mail.linkov.net> <87sgdb3xx5.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8941"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , Jeff Norden , Stefan Monnier , emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 31 01:14:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k1HlE-0002De-B6 for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Jul 2020 01:14:52 +0200 Original-Received: from localhost ([::1]:50336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1HlD-0001fz-4w for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Jul 2020 19:14:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1Hkj-0001GU-CS for emacs-devel@gnu.org; Thu, 30 Jul 2020 19:14:21 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:41995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1Hkd-0008NS-EJ; Thu, 30 Jul 2020 19:14:21 -0400 X-Originating-IP: 91.129.108.250 Original-Received: from mail.gandi.net (m91-129-108-250.cust.tele2.ee [91.129.108.250]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 9FECA60002; Thu, 30 Jul 2020 23:14:09 +0000 (UTC) In-Reply-To: <87sgdb3xx5.fsf@localhost> (Ihor Radchenko's message of "Wed, 29 Jul 2020 09:36:06 +0800") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/30 19:14:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253355 Archived-At: >> Any chance to fix also bug#40808? It's still open because there is >> no solution for isearching invisible text in org-mode. > > Thanks for pointing out this bug. Searching actually works fine on my > feature branch + patched isearch (though it is actually an unintended > side-effect). However, (setq isearch-lazy-count t) leaves the last > headline open. I will need to investigate this. Leaving the last headline open is a known bug fixed in https://debbugs.gnu.org/40808#8 Here it's explaned: "And also it fixes an old bug existed in previous Emacs versions where lazy-highlight didn't update lazy-highlighting when a hidden outline was automatically opened at the end of the file (I noticed this bug only now). So the condition ‘(eq search-invisible 'open)’ fixes an old bug..." >> The problem is that org-mode puts the text property 'invisible' >> only when the link is scrolled into view, I guess it puts the property >> using font-lock. >> >> So it seems org-mode needs to use font-lock-ensure on the line >> with the next search hit before calling isearch-filter-predicate >> on the found occurence. > > I am currently undecided about searchability of hidden text in links. Do > I understand correctly that you prefer the hidden parts of links to be > searchable? Either way is possible. If hidden parts are searchable, it > will be even possible to show them temporarily. The hidden parts of links should be searchable when the value of 'search-invisible' is 't' ("Match hidden text").