all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Amin Bandali <bandali@gnu.org>
To: "Mingde (Matthew) Zeng" <matthewzmd@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: [PATCHv3] erc: fix erc-reuse-buffers behavior
Date: Mon, 03 Aug 2020 11:14:35 -0400	[thread overview]
Message-ID: <87tuxjvk10.fsf@gnu.org> (raw)
In-Reply-To: <871rkr7pme.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Thanks for the patch, Matthew.

I just noticed Lars installed 6f94c2405f4c82b63da19de89549aff1fad7e594
on master, changing erc-generate-new-buffer-name.  Will your patch
require adjusting to accommodate Lars's changes?

Minor nits:

- Please omit the "Signed-off-by:" from your commit messages to Emacs.
- Consider dropping the second "* lisp/erc/erc.el" for (erc-cmd-JOIN),
  since the previous entry (erc-generate-new-buffer-name) was also a
  change to lisp/erc/erc.el.

Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

  reply	other threads:[~2020-08-03 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 13:58 [PATCHv3] erc: fix erc-reuse-buffers behavior Mingde (Matthew) Zeng
2020-08-03 15:14 ` Amin Bandali [this message]
2020-08-04  3:00   ` Mingde (Matthew) Zeng
2020-08-04  8:30     ` Lars Ingebrigtsen
2020-08-04 17:08       ` Mingde (Matthew) Zeng
2020-08-04 17:33         ` Lars Ingebrigtsen
2020-08-04 17:36           ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuxjvk10.fsf@gnu.org \
    --to=bandali@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=matthewzmd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.