gnus-group-make-nnir-group disappeared?

gnus-group-make-nnir-group disappeared?

[T.V Raman]

Function gnus-group-make-nnir-group seems to have disappeared from the
latest sources @HEAD,  intentional?

-- 
♉ Id: kg:/m/0285kf1  🦮

-- 
♉ Id: kg:/m/0285kf1  🦮

Re: gnus-group-make-nnir-group disappeared?

[Eric Abrahamsen]

"T.V Raman" <raman@google.com> writes:

> Function gnus-group-make-nnir-group seems to have disappeared from the
> latest sources @HEAD,  intentional?

Yes, this has been replaced by `gnus-group-make-search-group', though
there should be an obsolete alias added in there.

Re: gnus-group-make-nnir-group disappeared?

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 169 bytes --]

Thanks, please do add the obsolete alias so that code can continue to
work across emacs 28 and the presently released versions.
-- 
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: gnus-group-make-nnir-group disappeared?

[Andrew Cohen]

Sorry for the issues with this. It was a large change and I missed quite
a few things that need fixing. But Basil L. Contovounesios has
identified some more serious potential problems and I am trying to
decide if I should revert the whole thing.  If reverting seems
unnecessary I'll add the appropriate aliases.

BTW, in case you are fiddling with the current HEAD, the change should
be: 'gnus-group-make-nnir-group becomes
'gnus-group-read-ephemeral-search-group (still bound to "G G" in the
group buffer). The other new function mentioned by Eric,
'gnus-group-make-search-group, is for creating a permanent (rather than
ephemeral) group from a search.

Best,
Andy

>>>>> "TVR" == T V Raman <raman@google.com> writes:

    TVR> Thanks, please do add the obsolete alias so that code can
    TVR> continue to work across emacs 28 and the presently released
    TVR> versions.

Re: gnus-group-make-nnir-group disappeared?

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 129 bytes --]

Thanks -- reverting, working on a branch, then bringing it back in might
be worthwhile 
-- 
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: gnus-group-make-nnir-group disappeared?

[Andrew Cohen]

I pushed the aliases in so it should be OK for you now. 

>>>>> "TVR" == T V Raman <raman@google.com> writes:

    TVR> Thanks -- reverting, working on a branch, then bringing it back
    TVR> in might be worthwhile

Err, yeah. That's why its been developed on a  branch for two years :)
It was just my foolish attempt to merge without checking everything
twice. 

Re: gnus-group-make-nnir-group disappeared?

[Daniel Martín]

"T.V Raman" <raman@google.com> writes:

> Function gnus-group-make-nnir-group seems to have disappeared from the
> latest sources @HEAD,  intentional?

This is the commit that removed the function:
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ecfc13e41627511769e00a2d0a7568d5bdbe8a0d

I'm not familiar with the introduced change, but it seems the function
to use now should be gnus-group-make-search-group?

This API change is worth mentioning in NEWS, IMHO.

--
Daniel Martín