From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#19217: 25.0.50; `C-M-x' (`eval-defun') on a `defface' that is not top-level Date: Fri, 18 Sep 2020 15:36:31 +0200 Message-ID: <87tuvvgqao.fsf@gnus.org> References: <20141129191023.34112.qmail@mail.muc.de> <3e0d66d6-99b6-4e0d-a1eb-b7f2e3731ea7@default> <20141130195811.GB12974@acm.acm> <6718ace6-b672-40fc-a5bc-ea29eb155239@default> <20141206191057.GB3233@acm.acm> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34793"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , 19217@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 18 15:38:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJGaa-0008xK-HN for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 15:38:12 +0200 Original-Received: from localhost ([::1]:48008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJGaZ-0000Hz-J3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 09:38:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJGZR-0007eW-Uy for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 09:37:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJGZR-0003iQ-L6 for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 09:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJGZR-0003A6-Ho for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 09:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 13:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19217 X-GNU-PR-Package: emacs Original-Received: via spool by 19217-submit@debbugs.gnu.org id=B19217.160043620912135 (code B ref 19217); Fri, 18 Sep 2020 13:37:01 +0000 Original-Received: (at 19217) by debbugs.gnu.org; 18 Sep 2020 13:36:49 +0000 Original-Received: from localhost ([127.0.0.1]:41318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJGZE-00039f-Ri for submit@debbugs.gnu.org; Fri, 18 Sep 2020 09:36:49 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJGZC-00039P-JF for 19217@debbugs.gnu.org; Fri, 18 Sep 2020 09:36:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fYHVcYD6xmF3giDRQ2G6jTEb87ryQ7ccyNHb8oQHgWs=; b=Bi/ZAOuqbDv6xTuVNzj39CRhgX pC/NgHjqi7yNkBaKw2LGbQVfES9tzjOtcMVcmsDFdgck4exO5fGz5eVRhtjoC+P2ick3Ty77bXgfB d/CZayKnwta+jU4LfXmCpDGDVjvRfEGpST4nkczsr1jgf2sAMNBjidBSeuamQ9rsh0LM=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJGYz-0006KJ-B9; Fri, 18 Sep 2020 15:36:39 +0200 X-Now-Playing: Stina Nordenstam's _The World Is Saved_: "Get On With Your Life" In-Reply-To: <20141206191057.GB3233@acm.acm> (Alan Mackenzie's message of "Sat, 6 Dec 2014 19:10:57 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188305 Archived-At: Alan Mackenzie writes: > OK. I've hacked the following patch together, which wasn't actually all > that difficult. I've tested it out on a defvar, and it works there. It > gives C-x C-e the same special handling that C-M-x has for defvar's, > defcustom's, defface's, etc. It's incomplete (no documentation has been > changed), but it might do what you need. Please try it out. The patch no longer applies to Emacs 28, so I've respun it: diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index 72b94a57b4..7682e099f5 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -1190,7 +1190,8 @@ elisp--eval-last-sexp ;; Setup the lexical environment if lexical-binding is enabled. (elisp--eval-last-sexp-print-value (eval (macroexpand-all - (eval-sexp-add-defvars (elisp--preceding-sexp))) + (eval-sexp-add-defvars + (elisp--eval-defun-1 (macroexpand (elisp--preceding-sexp))))) lexical-binding) (if insert-value (current-buffer) t) no-truncate char-print-limit))) To recap, this allows `C-x C-e' on defvar/defface to work the same as `C-M-x' on those (when they are top-level). That these two work differently is a source of frustration, so I think it makes conceptual sense, but I'm not sure what the repercussions would be otherwise... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no