all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#43496: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here
@ 2020-09-18 21:35 Alex Bochannek
  2020-09-19 14:49 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Bochannek @ 2020-09-18 21:35 UTC (permalink / raw)
  To: 43496

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

The gnus-summary-catchup-from-here function also marks the current
article, which it fails to do if that article is the last one in the
summary buffer.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix edge case in gnus-summary-catchup-from-here --]
[-- Type: text/x-patch; name=gnus-sum.el.diff, Size: 506 bytes --]

diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 2f0ea0c58f..8e27a94e5b 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -11537,7 +11537,7 @@ gnus-summary-catchup-from-here
     (gnus-save-hidden-threads
       (let ((beg (point)))
 	;; We check that there are unread articles.
-	(when (or all (gnus-summary-find-next))
+	(when (or all (gnus-summary-last-article-p) (gnus-summary-find-next))
 	  (gnus-summary-catchup all t beg nil t)))))
   (gnus-summary-position-point))

[-- Attachment #3: Type: text/plain, Size: 10 bytes --]

-- 
Alex.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#43496: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here
  2020-09-18 21:35 bug#43496: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here Alex Bochannek
@ 2020-09-19 14:49 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2020-09-19 14:49 UTC (permalink / raw)
  To: Alex Bochannek; +Cc: 43496

Alex Bochannek <alex@bochannek.com> writes:

> The gnus-summary-catchup-from-here function also marks the current
> article, which it fails to do if that article is the last one in the
> summary buffer.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-19 14:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-18 21:35 bug#43496: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here Alex Bochannek
2020-09-19 14:49 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.