From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master d067ac5: Remove more compat code from prolog.el
Date: Fri, 25 Sep 2020 15:49:30 +0200 [thread overview]
Message-ID: <87tuvmnez9.fsf@gnus.org> (raw)
In-Reply-To: <jwv7dsijat5.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 25 Sep 2020 08:39:23 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> @@ -1999,7 +1997,7 @@ Argument BOUND is a buffer position limiting searching."
>> (if (eq prolog-system 'mercury)
>> (list
>> (regexp-opt prolog-directives-i 'words)
>> - 0 'prolog-warning-face)))
>> + 0 prolog-warning-face)))
>> ;; Inferior mode specific patterns
>> (prompt
>> ;; FIXME: Should be handled by comint already.
>
> I think this one is wrong: the font-lock data-structure built here
> should contain at this position an *expression* that returns a face when
> passed to `eval`.
>
> IOW with the above change the value held by `prolog-warning-face` needs
> to be "an expression that evaluates to a face" rather than "a face name".
All the other places there used the variable instead of the symbol,
I think? For instance:
;; FIXME: Add to compilation-error-regexp-alist instead.
(cond
((eq prolog-system 'sicstus)
'("[ \t]*[0-9]+[ \t]+[0-9]+[ \t]*\\(Fail\\):"
1 prolog-warning-face))
((eq prolog-system 'swi)
'("[ \t]*\\(Fail\\):[ \t]*([ \t0-9]*)" 1 prolog-warning-face))
So I was just trying to make it more consistent.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-09-25 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200925093755.19433.41297@vcs0.savannah.gnu.org>
[not found] ` <20200925093756.C7849209D4@vcs0.savannah.gnu.org>
2020-09-25 12:39 ` master d067ac5: Remove more compat code from prolog.el Stefan Monnier
2020-09-25 13:49 ` Lars Ingebrigtsen [this message]
2020-09-25 14:04 ` Stefan Monnier
2020-09-25 14:06 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuvmnez9.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.