From: "João Távora" <joaotavora@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets <andreyk.mad@gmail.com>
Subject: bug#33740: [PATCH] Customizable flymake mode-line indicator
Date: Tue, 29 Dec 2020 14:18:29 +0000 [thread overview]
Message-ID: <87tus4g0ga.fsf@gmail.com> (raw)
In-Reply-To: <87bledgxql.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 29 Dec 2020 03:19:30 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> I've now altered format-spec to (optionally) return a list of strings,
>> which makes the previously proposed patch work, so I've now pushed it
>> (after rebasing it). It seems to work fine in my test cases, but it
>> hasn't been tested extensively.
>
> (João, if you could have a look over the resulting code change (which is
> mostly just indentation changes, but also changes a lot of the quoting),
> that'd be nice.)
I've just reverted the patch: it is seriously flawed. I don't know if
"format-spec" allows this, but the previous indicators semantics were to
omit some counters (notably the notes counter) completely if the count
was 0. This is why when opening the *scratch* buffer, which has 0
notes, the function you touched now exits non-locally with an error.
I'm not sure you've taken these details into account, and they're quite
an important feature that I don't think we can afford to lose.
So better put the patch in a side branch and decide if we want to
overhaul format-spec to allow for these things, or maybe just use the
more powerful existing mode-line language for this, perhaps breaking up
that big function into well-behaved pieces that users can compose.
Thanks,
João
next prev parent reply other threads:[~2020-12-29 14:18 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 9:19 bug#33740: [PATCH] Customizable flymake mode-line indicator Andrii Kolomoiets
2019-01-04 20:27 ` João Távora
2019-06-22 14:15 ` Štěpán Němec
2019-09-16 22:22 ` Lars Ingebrigtsen
2019-09-17 6:09 ` Eli Zaretskii
2019-09-17 11:57 ` Lars Ingebrigtsen
2019-09-17 12:13 ` Eli Zaretskii
2019-09-17 12:22 ` Lars Ingebrigtsen
2019-09-17 12:44 ` Eli Zaretskii
2019-09-18 13:38 ` Lars Ingebrigtsen
2019-09-18 14:09 ` Lars Ingebrigtsen
2019-09-19 15:28 ` Lars Ingebrigtsen
2019-09-19 15:55 ` Lars Ingebrigtsen
2019-09-19 16:23 ` Lars Ingebrigtsen
2019-09-19 17:26 ` Eli Zaretskii
2019-09-20 12:32 ` Lars Ingebrigtsen
2019-09-20 13:06 ` Eli Zaretskii
2019-09-20 13:13 ` Lars Ingebrigtsen
2019-09-17 14:07 ` João Távora
2019-09-18 13:40 ` Lars Ingebrigtsen
2019-09-18 13:59 ` João Távora
2019-09-19 15:39 ` Lars Ingebrigtsen
2019-09-20 13:07 ` João Távora
2019-09-21 7:54 ` Lars Ingebrigtsen
2019-09-22 20:55 ` Juri Linkov
2019-09-23 9:18 ` João Távora
2019-09-23 18:10 ` Lars Ingebrigtsen
2019-09-23 9:25 ` João Távora
2019-09-23 18:11 ` Lars Ingebrigtsen
2019-09-18 14:02 ` Noam Postavsky
2020-12-29 2:12 ` Lars Ingebrigtsen
2020-12-29 2:19 ` Lars Ingebrigtsen
2020-12-29 13:52 ` João Távora
2020-12-29 14:14 ` Lars Ingebrigtsen
2020-12-29 14:18 ` João Távora [this message]
2020-12-29 14:22 ` Lars Ingebrigtsen
2020-12-29 15:13 ` João Távora
2020-12-30 3:22 ` Lars Ingebrigtsen
2020-12-30 9:28 ` João Távora
2020-12-30 20:16 ` Eli Zaretskii
2020-12-30 21:13 ` João Távora
2020-12-31 14:05 ` João Távora
2021-01-01 10:56 ` Lars Ingebrigtsen
2021-01-02 11:27 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tus4g0ga.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=33740@debbugs.gnu.org \
--cc=andreyk.mad@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.