From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: Patch to avoid flicker in Isearch with lazy count Date: Thu, 28 Jan 2021 08:32:48 +0100 Message-ID: <87tur1bjof.fsf@gmail.com> References: <87r1m6jsk7.fsf@gmail.com> <87lfce2ruh.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28507"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 28 08:34:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l51oc-0007GJ-TI for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jan 2021 08:34:06 +0100 Original-Received: from localhost ([::1]:48658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l51ob-0004WJ-Sj for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jan 2021 02:34:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l51nU-00042S-H3 for emacs-devel@gnu.org; Thu, 28 Jan 2021 02:32:56 -0500 Original-Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]:43952) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l51nS-0005Fh-PC for emacs-devel@gnu.org; Thu, 28 Jan 2021 02:32:56 -0500 Original-Received: by mail-ej1-x62d.google.com with SMTP id a10so6254533ejg.10 for ; Wed, 27 Jan 2021 23:32:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=0QZwBtoW0Bk8iMbDVSWyX2roM8I3PXL6Bn9daXam4Qc=; b=HQvgC3mXytOgLNRmGOV7LG1wiKU/bAYeuHqiRPJPQ9XvRXyKWbA4/aPWYDsFLvadlP yFYfOu4ocIgVmr71PHg15EVbwSEssnCqSTOoOqHElQgdXs06imiRh0iLGgrCq8pCadWY Btf7zd60CW8ZUdviFfbMAM6QN+ZZPbeQUQKd/Z9fzQirUlDFcuyx3f/gU4APogNH/JL3 rzAuOreEtmQ9SZ5Nx1LHwFxOIDdbPXj2vm6VDPo/ZB4idQi5bZQKmqLMWbOLgaqYM2cy Z8wtijj/KMCsQOSB89lmnQVxC2tJfCCDrjkZKhVf1s6P2bt14YjSLLb0q0Oc9pC+EnZQ YBlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=0QZwBtoW0Bk8iMbDVSWyX2roM8I3PXL6Bn9daXam4Qc=; b=a+kxEr2CDwS+7VgqF75yHiKLg6ppWH1+wFztKsvd9cp8EInFCjiXKVFqVQGgli0XQK A/PSuef1hcXkMRj3wBgYRP6SJl8ClLU0RDVp8FvHIP95/IUlOhS23wlac6sFD3S7PLJ8 naqgJlYGzvvYxRXCZnI4PA7++OdYPxqbiWLq8yYQnS24HJYp75LCYCP37riCuBr2Pty5 2t6NkOVSenyy6NsM1+2d4np/sC5qopqVrbVXkSC32z6u9oKIa4yh1zkN4scMSWt0Iflk aS5O69sOU5TSIWFZ/oaYMQ8Krq6ITNsjLKaolFv8HirGm7mMDLyXzzRTeTwpiRUISMxI G6ew== X-Gm-Message-State: AOAM533hNXTp+58FjQa9vo+B8rAWM6HbYn4FzScrHbs0PgxWwFR0LutA mcOAVIHqfz5Ik4gzkX6JFWsyoZfnVrY= X-Google-Smtp-Source: ABdhPJxE8r1IxdpdBDfzZaIEBM0YjjrTKeCsbj4Yt6oElo8Y0+G9NcxRqb8jUjKAePoafrBTuogwDg== X-Received: by 2002:a17:906:1c4b:: with SMTP id l11mr9963706ejg.155.1611819170538; Wed, 27 Jan 2021 23:32:50 -0800 (PST) Original-Received: from ars3 ([2a02:908:2211:8540::16e5]) by smtp.gmail.com with ESMTPSA id t11sm2429841edd.1.2021.01.27.23.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 23:32:49 -0800 (PST) In-Reply-To: <87lfce2ruh.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 27 Jan 2021 19:48:54 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263538 Archived-At: Hi Juri, On Wed, 27 Jan 2021 at 19:48, Juri Linkov wrote: > Does this mean that for users who already customized > =E2=80=98lazy-highlight-initial-delay=E2=80=99 to 0, now it's recommended= to > revert such customization, and leave it at its default non-zero value? That's right. I'll make sure to add a NEWS entry and fix those typos in the next iteration of the patch. > Currently, run-with-idle-timer is used for lazy-highlight-initial-delay, > and run-at-time for lazy-highlight-interval. But you replaced all > with run-with-idle-timer. Any reason not to use run-at-time > for lazy-highlight-interval to reduce delays for quickly finishing > the already started lazily highlighting successive matches? That was just to avoid repeating a piece of code at several places. It makes no difference with the default =E2=80=98lazy-highlight-interval=E2=80= =99 of 0, right? But it might actually be better to make =E2=80=98lazy-highlight-delay-max-chars=E2=80=99 to affect only =E2=80=98lazy-highlight-initial-delay=E2=80=99 and not =E2=80=98lazy-highli= ght-interval=E2=80=99. What do you think? Best, Augusto