all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Augusto Stoffel <arstoffel@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: Patch to avoid flicker in Isearch with lazy count
Date: Thu, 28 Jan 2021 08:32:48 +0100	[thread overview]
Message-ID: <87tur1bjof.fsf@gmail.com> (raw)
In-Reply-To: <87lfce2ruh.fsf@mail.linkov.net> (Juri Linkov's message of "Wed,  27 Jan 2021 19:48:54 +0200")

Hi Juri,

On Wed, 27 Jan 2021 at 19:48, Juri Linkov <juri@linkov.net> wrote:

> Does this mean that for users who already customized
> ‘lazy-highlight-initial-delay’ to 0, now it's recommended to
> revert such customization, and leave it at its default non-zero value?

That's right.  I'll make sure to add a NEWS entry and fix those typos in
the next iteration of the patch.

> Currently, run-with-idle-timer is used for lazy-highlight-initial-delay,
> and run-at-time for lazy-highlight-interval.  But you replaced all
> with run-with-idle-timer.  Any reason not to use run-at-time
> for lazy-highlight-interval to reduce delays for quickly finishing
> the already started lazily highlighting successive matches?

That was just to avoid repeating a piece of code at several places.  It
makes no difference with the default ‘lazy-highlight-interval’ of 0,
right?  But it might actually be better to make
‘lazy-highlight-delay-max-chars’ to affect only
‘lazy-highlight-initial-delay’ and not ‘lazy-highlight-interval’.  What
do you think?

Best,
Augusto



  reply	other threads:[~2021-01-28  7:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 15:41 Patch to avoid flicker in Isearch with lazy count Augusto Stoffel
2021-01-27 17:48 ` Juri Linkov
2021-01-28  7:32   ` Augusto Stoffel [this message]
2021-01-28  9:06     ` Juri Linkov
2021-01-28 11:17       ` Augusto Stoffel
2021-01-28 18:48         ` Juri Linkov
2021-01-29 17:50       ` Augusto Stoffel
2021-01-30 18:50         ` Juri Linkov
2021-09-04 22:43           ` Stefan Kangas
2021-09-05  7:54             ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tur1bjof.fsf@gmail.com \
    --to=arstoffel@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.