From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22763: 25.1.50; Feature Request -- A faster method to obtain line number at position. Date: Sun, 07 Feb 2021 19:23:53 +0100 Message-ID: <87tuqnzqh2.fsf@gnus.org> References: <83y4aclofm.fsf@gnu.org> <878s7z532u.fsf@gnus.org> <87y2fz3lpe.fsf@gnus.org> <87h7mn22ls.fsf@gnus.org> <83eehrn408.fsf@gnu.org> <87y2fzzqxb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 22763@debbugs.gnu.org, esq@lawlist.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 07 19:25:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8okB-0007IO-LV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Feb 2021 19:25:11 +0100 Original-Received: from localhost ([::1]:35288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8okA-0006CT-Iw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Feb 2021 13:25:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8ok2-0006CC-DS for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 13:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37185) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8ok2-0004t0-6N for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 13:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l8ok2-0001gG-3N for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 13:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2021 18:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22763-submit@debbugs.gnu.org id=B22763.16127222606402 (code B ref 22763); Sun, 07 Feb 2021 18:25:02 +0000 Original-Received: (at 22763) by debbugs.gnu.org; 7 Feb 2021 18:24:20 +0000 Original-Received: from localhost ([127.0.0.1]:48731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8ojL-0001fC-OW for submit@debbugs.gnu.org; Sun, 07 Feb 2021 13:24:19 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:38556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8ojK-0001ey-0A for 22763@debbugs.gnu.org; Sun, 07 Feb 2021 13:24:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0uCn55e6D9lqfYmyzuD7SglwBNtOuXvduy+28uQf43M=; b=BwpBKQ9ribtuPBR4nDP92OKZAS IhwkJaFptyU6u1a1ejQN3LRuqaLGzIXrVvFs7N7aImLQ+X0Otuix+UVyAE0+FG16Y1pP6gyY6m5ZJ rECmiFlrMf0P08GoV2j1eUeD3Zd224p9qxZiikD8CBTmDLuWoLqPYCE1qvNpdN3VXi2s=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8oiw-0003Q1-4c; Sun, 07 Feb 2021 19:24:04 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUkGRdVIxxoSSek Rh7////0Jn+1AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UCBQsDEP2ML4UAAAGqSURBVDjLjVOBjcMw CIR0AcALGLJAHe+/2x+4SfrSV1+kuNRnDBxnoo+myuQqrKZ9I+YOv4DwDd9gD3hdNcK89wphEsIp FqHOLJp/6X9j25zc/0AKiC+uQPLN3DMpknMW/yqXgs0DXUQ3lLoxFjurqjOKKoVRdvBXmb6wu2t+ 31TVG7jc2nwDhq4wfPx8p2kMLGITDe7z2pV1A7c5n/SYU+5rsee2zzmH7HOorPSoYp52wEW+E5iD saGxzwDYsuKkCIDKpmLhHHOYPi8AkUZmmzUAxEcCWgR4RhvpfmRJjUZOhmo67MLCyIykDx2OoeUU uPoQ9JA9boFAX904JxzT90yCwEd0quugSyYLHXMWYLMvzpMXMlSgOwuASNqqSxSOss2tiBjtZAzU OkQNS2A/Lo41HwEmxJxhDZ2eI8QQOSnIpeGhxAncJtoe2o9TAzeQsWt0UgAYyVFK/VyKwDnsjCI6 D4K7FyApdtyi9c6yFl2Cg5f0AuN6jJe4as45OD1VqUtoda/Kegt1mhdX8hrxLWldrpSA26VzJv2l +tt9U/aHh8IlDCq1/GM/Y+AwNiS2qcAAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDItMDVUMTE6 MDM6MTUrMDA6MDAgZXUcAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAyLTA1VDExOjAzOjE1KzAw OjAwUTjNoAAAAABJRU5ErkJggg== X-Now-Playing: Mia Doi Todd & Company's _Music for A Midsummer Night's Dream_: "We Are Love" In-Reply-To: <87y2fzzqxb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 07 Feb 2021 19:14:08 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199533 Archived-At: Lars Ingebrigtsen writes: >> find_newline does the same as display_count_lines: it calls memchr. >> But it also maintains a newline cache. If you disable that cache (by >> turning of cache-long-scans), you might see a different speedup. > > Shouldn't the cache speed things up? No, you're right -- if I set `cache-long-scans' to nil and `line-number-at-pos' in Emacs 27 becomes ~8x faster in my test, which is currently (with-temp-buffer (setq cache-long-scans nil) (dotimes (_ 1000) (insert-file-contents "~/src/emacs/trunk/src/ChangeLog.11") (goto-char (point-max))) (benchmark-run 1 (dotimes (i 1000) (goto-char (/ (buffer-size) 1000)) (line-number-at-pos (point))))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no