From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 46827@debbugs.gnu.org
Subject: bug#46827: Broken initial size of GTK3 frame
Date: Fri, 14 May 2021 21:10:25 +0300 [thread overview]
Message-ID: <87tun58bj2.fsf@mail.linkov.net> (raw)
In-Reply-To: <74ceb571-7fbb-f018-8c29-41cc1d3785d0@gmx.at> (martin rudalics's message of "Fri, 14 May 2021 09:08:20 +0200")
>> Accoring to window-total-height, the currently used rounding
>> in x_change_tab_bar_height corresponds to 'ceiling':
>>
>> return make_fixnum (EQ (round, Qceiling)
>> ? ((w->pixel_height + unit - 1) /unit)
>>
>> On a TTY where the frame line height is 1, this gives the correct result.
>> But not on a GUI where the frame line height is measured in pixels.
>>
>> When the argument 'round' of window-total-height is 'floor',
>> it uses the formula without subtracting 1 that works on a GUI too:
>>
>> : (w->pixel_height / unit));
>>
>> This patch fixes this in x_change_tab_bar_height. Do you think the same
>> fix should be applied to x_change_tool_bar_height as well?
>
> What does your patch fix?
There are no more oscillations between 1 and 2 on a GUI.
> With a sufficiently small default font this will still return a value > 1.
I use very small font, and the value is always 1. Only when the tab bar
is wrapped, the value becomes 2.
> In either case, the height of the frame's inner rectangle plus those
> of internal tab, tool and menu bar should equal the height of the
> native rectangle in lines. Did you check that?
I don't know how to check this.
> In my experience, there's no way to make column/line based variables and
> functions always DTRT on a GUI. Code should avoid them.
Is it possible to avoid this when tab-bar-lines are calculated?
next prev parent reply other threads:[~2021-05-14 18:10 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 9:31 bug#46827: Broken initial size of GTK3 frame martin rudalics
2021-02-28 18:09 ` Eli Zaretskii
2021-03-01 8:32 ` martin rudalics
2021-03-01 9:46 ` martin rudalics
2021-03-01 8:31 ` martin rudalics
2021-03-01 10:15 ` Robert Pluim
2021-03-01 12:38 ` martin rudalics
2021-03-01 13:30 ` Robert Pluim
2021-03-01 13:53 ` Robert Pluim
2021-03-01 18:03 ` martin rudalics
2021-03-01 18:23 ` Robert Pluim
2021-03-01 18:32 ` Robert Pluim
2021-03-01 19:05 ` martin rudalics
2021-03-01 19:04 ` martin rudalics
2021-03-01 20:00 ` Robert Pluim
2021-03-02 8:24 ` martin rudalics
2021-03-01 19:49 ` Stephen Berman
2021-03-02 8:24 ` martin rudalics
2021-03-02 9:07 ` martin rudalics
2021-03-02 10:11 ` Robert Pluim
2021-03-02 14:11 ` Eli Zaretskii
2021-03-02 16:07 ` martin rudalics
2021-03-02 16:35 ` Eli Zaretskii
2021-03-03 8:48 ` martin rudalics
2021-03-03 9:05 ` Eli Zaretskii
2021-03-03 9:40 ` martin rudalics
2021-03-06 11:15 ` Eli Zaretskii
2021-03-06 19:28 ` martin rudalics
2021-03-02 9:17 ` Stephen Berman
2021-03-02 10:02 ` martin rudalics
2021-03-01 18:03 ` martin rudalics
2021-03-01 14:07 ` Eli Zaretskii
2021-03-01 18:04 ` martin rudalics
2021-04-27 8:23 ` martin rudalics
2021-04-29 16:13 ` Juri Linkov
2021-04-29 17:06 ` martin rudalics
2021-04-29 23:06 ` Juri Linkov
2021-04-30 6:26 ` martin rudalics
2021-04-30 17:12 ` Juri Linkov
2021-04-30 17:37 ` martin rudalics
2021-05-01 20:06 ` Juri Linkov
2021-05-02 7:38 ` martin rudalics
2021-05-02 20:46 ` Juri Linkov
2021-05-03 7:49 ` martin rudalics
2021-05-03 16:40 ` Juri Linkov
2021-05-03 16:51 ` martin rudalics
2021-05-03 17:01 ` Juri Linkov
2021-05-03 17:32 ` martin rudalics
2021-05-04 8:07 ` martin rudalics
2021-05-04 21:33 ` Juri Linkov
2021-05-05 7:25 ` martin rudalics
2021-05-05 20:34 ` Juri Linkov
2021-05-06 7:45 ` martin rudalics
2021-05-07 16:52 ` Juri Linkov
2021-05-10 8:23 ` martin rudalics
2021-05-10 20:39 ` Juri Linkov
2021-05-11 8:44 ` martin rudalics
2021-05-11 17:49 ` Juri Linkov
2021-05-12 8:47 ` martin rudalics
2021-05-12 17:28 ` Juri Linkov
2021-05-13 7:54 ` martin rudalics
2021-05-13 16:24 ` Juri Linkov
2021-05-14 7:08 ` martin rudalics
2021-05-14 18:10 ` Juri Linkov [this message]
2021-05-15 7:56 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tun58bj2.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=46827@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.