bug#49645: 28.0.50; Bookmark line highlighting remain stuck

bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Marius Kjeldahl]

A few months ago highlighting the bookmark lines got turned on by
default. While it's possible to delete bookmarks, the highlighting
seems to remain stuck. Setting and clearing many temporary bookmarks
while working in code means the the code gets littered with such
highlights. I haven't found any way of cleaning up those highlights,
except killing the buffer and reloading the file. I've turned it off
by setting bookmark-fontify. But surely, the current behaviour must be
considered a bug.

Thanks,

Marius K.

In GNU Emacs 28.0.50 (build 2, x86_64-apple-darwin20.6.0, NS
appkit-2022.60 Version 11.5 (Build 20G5052c))
 of 2021-07-05 built on iMac
Windowing system distributor 'Apple', version 10.3.2022
System Description:  macOS 11.5

Configured using:
 'configure --enable-locallisppath=/usr/local/share/emacs/site-lisp
 --infodir=/usr/local/Cellar/emacs-head@28/28.0.50_1/share/info/emacs
 --prefix=/usr/local/Cellar/emacs-head@28/28.0.50_1 --without-x
 --without-dbus --with-native-compilation --without-imagemagick
 --with-modules --with-gnutls --with-rsvg --with-xml2 --with-ns
 --disable-ns-self-contained 'CFLAGS=-O2 -march=native
 -I/usr/local/opt/gcc/include' 'LDFLAGS=-L/usr/local/lib/gcc/11
 -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include
 -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include''

Configured features:
ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS XIM
ZLIB

Important settings:
  value of $LANG: en_NO.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  global-company-mode: t
  company-mode: t
  projectile-mode: t
  helm-mode: t
  helm--remap-mouse-mode: t
  async-bytecomp-package-mode: t
  electric-pair-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  rainbow-delimiters-mode: t
  shell-dirtrack-mode: t
  recentf-mode: t
  show-paren-mode: t
  display-time-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/Users/marius/.config/emacs/elpa/transient-20210712.1626/transient
hides /usr/local/Cellar/emacs-head@28/28.0.50_1/share/emacs/28.0.50/lisp/transient

Features:
(shadow sort mail-extr emacsbug message rmc puny rfc822 mml mml-sec
gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils helm-command helm-elisp
helm-eval edebug backtrace company-oddmuse company-keywords
company-etags etags fileloop generator xref project company-gtags
company-dabbrev-code company-dabbrev company-files company-clang
company-capf company-cmake company-semantic company-template
company-bbdb company helm-swoop winner tramp-archive tramp-gvfs dbus
helm-for-files helm-bookmark helm-adaptive helm-info bookmark
helm-external helm-net xml server powerline powerline-separators
powerline-themes projectile grep ibuf-ext ibuffer ibuffer-loaddefs
helm-mode helm-files filenotify image-dired image-mode exif dired-x
dired-aux dired dired-loaddefs helm-buffers helm-occur helm-tags
helm-locate helm-grep helm-regexp helm-utils helm-help helm-types helm
async-bytecomp helm-global-bindings helm-easymenu helm-source
helm-multi-match helm-lib async helm-config phi-search-mc cl
multiple-cursors mc-separate-operations rectangular-region-mode
mc-mark-pop mc-edit-lines mc-hide-unmatched-lines-mode mc-mark-more
mc-cycle-cursors multiple-cursors-core rect phi-search phi-search-core
elec-pair org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint org-pcomplete org-list org-faces
org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval
org-table ol org-keys org-compat advice org-macs org-loaddefs cal-menu
calendar cal-loaddefs erc-services erc-networks erc-goodies erc
erc-backend pp erc-loaddefs flycheck find-func dash easy-mmode pcase
jka-compr let-alist rainbow-delimiters color compile
text-property-search tramp-cache tramp-sh tramp tramp-loaddefs trampver
tramp-integration files-x tramp-compat shell pcomplete comint ansi-color
ring parse-time iso8601 time-date ls-lisp format-spec recentf
tree-widget wid-edit ffap thingatpt edmacro kmacro material-light-theme
paren time cus-load finder-inf epa-file epa derived epg epg-config info
package browse-url url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util mailcap url-handlers
url-parse auth-source eieio eieio-core eieio-loaddefs password-cache
json map url-vars comp comp-cstr warnings subr-x rx cl-seq cl-macs
cl-extra help-mode seq byte-opt gv bytecomp byte-compile cconv
cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads kqueue cocoa ns lcms2
multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 547290 18189)
 (symbols 48 32443 2)
 (strings 32 104157 6327)
 (string-bytes 1 3958597)
 (vectors 16 44953)
 (vector-slots 8 760612 34910)
 (floats 8 325 415)
 (intervals 56 911 160)
 (buffers 992 15))

bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Lars Ingebrigtsen]

Marius Kjeldahl <marius.kjeldahl@gmail.com> writes:

> But surely, the current behaviour must be considered a bug.

Yup.  There's been so much pushback on the highlighting (in addition to
it not working very well) that I'm wondering whether we should just
revert it at this point.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Marius Kjeldahl <marius.kjeldahl@gmail.com> writes:
>
>> But surely, the current behaviour must be considered a bug.
>
> Yup.  There's been so much pushback on the highlighting (in addition to
> it not working very well) that I'm wondering whether we should just
> revert it at this point.

Just linking to the relevant discussion for posterity:
https://bugs.gnu.org/48179

Thanks,

-- 
Basil

bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Christopher League]

Marius Kjeldahl <marius.kjeldahl@gmail.com> writes:

> A few months ago highlighting the bookmark lines got turned on
> by default. While it's possible to delete bookmarks, the
> highlighting seems to remain stuck. Setting and clearing many
> temporary bookmarks while working in code means the the code
> gets littered with such highlights. I haven't found any way of
> cleaning up those highlights, except killing the buffer and
> reloading the file. I've turned it off by setting
> bookmark-fontify. But surely, the current behaviour must be
> considered a bug.

Hi Marius,

I think today we committed a fix for this issue of stuck bookmark
highlights:
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=142961bcdfb202ca3347a085e55c87b164bb2fb9

Can you confirm that it resolves the problem you saw?

If you're not building from git regularly, you should be able to
just download the most recent bookmark.el from here and
‘eval-buffer’ it to test:
https://git.savannah.gnu.org/cgit/emacs.git/plain/lisp/bookmark.el

In my analysis, clearing the highlight worked previously when
using ‘bookmark-delete’, but not when overwriting an existing
bookmark with a new location. The current version should fix it.
Thanks.

CL

bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Marius Kjeldahl]

I rebuilt emacs from head (brew reinstall emacs-head@28 --with-cocoa
--with-native-comp) and it still does seem to work.

If I set four bookmarks and then delete all bookmarks, only the last
one set will actually be cleaned up visually. Even though there are no
active bookmarks any longer, the three first will still have
highlighted lines.

Thanks,

Marius K.

On Sun, Jul 25, 2021 at 4:34 PM Christopher League
<league@contrapunctus.net> wrote:
>
> Marius Kjeldahl <marius.kjeldahl@gmail.com> writes:
>
> > A few months ago highlighting the bookmark lines got turned on
> > by default. While it's possible to delete bookmarks, the
> > highlighting seems to remain stuck. Setting and clearing many
> > temporary bookmarks while working in code means the the code
> > gets littered with such highlights. I haven't found any way of
> > cleaning up those highlights, except killing the buffer and
> > reloading the file. I've turned it off by setting
> > bookmark-fontify. But surely, the current behaviour must be
> > considered a bug.
>
> Hi Marius,
>
> I think today we committed a fix for this issue of stuck bookmark
> highlights:
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=142961bcdfb202ca3347a085e55c87b164bb2fb9
>
> Can you confirm that it resolves the problem you saw?
>
> If you're not building from git regularly, you should be able to
> just download the most recent bookmark.el from here and
> ‘eval-buffer’ it to test:
> https://git.savannah.gnu.org/cgit/emacs.git/plain/lisp/bookmark.el
>
> In my analysis, clearing the highlight worked previously when
> using ‘bookmark-delete’, but not when overwriting an existing
> bookmark with a new location. The current version should fix it.
> Thanks.
>
> CL

bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Marius Kjeldahl]

Still does NOT seem to work, sorry about that.

Thanks,

Marius K.

On Sun, Jul 25, 2021 at 11:14 PM Marius Kjeldahl
<marius.kjeldahl@gmail.com> wrote:
>
> I rebuilt emacs from head (brew reinstall emacs-head@28 --with-cocoa
> --with-native-comp) and it still does seem to work.
>
> If I set four bookmarks and then delete all bookmarks, only the last
> one set will actually be cleaned up visually. Even though there are no
> active bookmarks any longer, the three first will still have
> highlighted lines.
>
> Thanks,
>
> Marius K.
>
> On Sun, Jul 25, 2021 at 4:34 PM Christopher League
> <league@contrapunctus.net> wrote:
> >
> > Marius Kjeldahl <marius.kjeldahl@gmail.com> writes:
> >
> > > A few months ago highlighting the bookmark lines got turned on
> > > by default. While it's possible to delete bookmarks, the
> > > highlighting seems to remain stuck. Setting and clearing many
> > > temporary bookmarks while working in code means the the code
> > > gets littered with such highlights. I haven't found any way of
> > > cleaning up those highlights, except killing the buffer and
> > > reloading the file. I've turned it off by setting
> > > bookmark-fontify. But surely, the current behaviour must be
> > > considered a bug.
> >
> > Hi Marius,
> >
> > I think today we committed a fix for this issue of stuck bookmark
> > highlights:
> > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=142961bcdfb202ca3347a085e55c87b164bb2fb9
> >
> > Can you confirm that it resolves the problem you saw?
> >
> > If you're not building from git regularly, you should be able to
> > just download the most recent bookmark.el from here and
> > ‘eval-buffer’ it to test:
> > https://git.savannah.gnu.org/cgit/emacs.git/plain/lisp/bookmark.el
> >
> > In my analysis, clearing the highlight worked previously when
> > using ‘bookmark-delete’, but not when overwriting an existing
> > bookmark with a new location. The current version should fix it.
> > Thanks.
> >
> > CL

bug#49645: [External] : bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Drew Adams]

You are all welcome to take a look at the Bookmark+ code
for highlighting bookmark locations.  It doesn't have a
problem wrt movement or deletion of bookmarks.

E.g., if you set a bookmark at one location in a buffer,
and you later set it at a different location in that
buffer, its highlight is automatically moved to the new
location.  And if you delete a bookmark, its highlight
disappears.

The code is in file bookmark+-lit.el, here:

https://www.emacswiki.org/emacs/download/bookmark%2b-lit.el

A description is here:

https://www.emacswiki.org/emacs/BookmarkPlus#HighlightingBookmarkLocations


There, you'll also see this text, which is about a highlight
moving along with the bookmarked text:

 "Note: A region, position, or line highlight acts more or
  less like an Emacs marker: it moves with the surrounding
  text.  As you edit the text in the buffer, the highlighted
  location can thus become out of sync with the recorded
  position.  This is normal.  When you jump to the bookmark,
  its highlight is automatically repositioned to the
  recorded location, possibly adjusted according to the
  surrounding context."

That wasn't the situation raised by this bug, but it's
related.  A bookmark's location needs to keep its highlight,
even as editing text around it moves it around.  That's in
addition to the fact that if you change the bookmark location
then its highlight needs to reflect that.
___

And as for all the pushback wrt the introduction of bookmark
highlighting: Bookmark+ highlighting is OFF by default, and
it's configurable per bookmark.  It's not an all-or-nothing
thing.  The same should be true for vanilla Emacs bookmark
highlighting, IMO.

bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Lars Ingebrigtsen]

Marius Kjeldahl <marius.kjeldahl@gmail.com> writes:

> A few months ago highlighting the bookmark lines got turned on by
> default. While it's possible to delete bookmarks, the highlighting
> seems to remain stuck. Setting and clearing many temporary bookmarks
> while working in code means the the code gets littered with such
> highlights.

This was a year ago, but not resolved at the time.

If this is still happening in Emacs 29, do you have a complete recipe to
reproduce the problem, starting from "emacs -Q"?

bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Marius Kjeldahl]

I've been running master/29 the last year and haven't been bothered
about this bug for a long time, so I believe it can be marked as
fixed.

Thanks,

Marius K.

On Sun, 21 Aug 2022 at 20:03, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> Marius Kjeldahl <marius.kjeldahl@gmail.com> writes:
>
> > A few months ago highlighting the bookmark lines got turned on by
> > default. While it's possible to delete bookmarks, the highlighting
> > seems to remain stuck. Setting and clearing many temporary bookmarks
> > while working in code means the the code gets littered with such
> > highlights.
>
> This was a year ago, but not resolved at the time.
>
> If this is still happening in Emacs 29, do you have a complete recipe to
> reproduce the problem, starting from "emacs -Q"?
>

bug#49645: 28.0.50; Bookmark line highlighting remain stuck

[Lars Ingebrigtsen]

Marius Kjeldahl <marius.kjeldahl@gmail.com> writes:

> I've been running master/29 the last year and haven't been bothered
> about this bug for a long time, so I believe it can be marked as
> fixed.

Thanks; closing this report, then.