[ELPA] New package: ERC

[Amin Bandali <bandali@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1662 bytes --]

Hello,

It's about time we added ERC to GNU ELPA. :)

The first attached patch against elpa.git does that.

The second patch allows for a nonexistent erc-loaddefs, since that
file would not generated for the GNU ELPA package, and instead an
erc-autoloads.el would be generated and (IIRC) automatically loaded.

I believe the above two are enough to get ERC onto GNU ELPA, with a
minimum required Emacs version of 27.

I would like to lower that lower bound by a few Emacs major versions
so that users on older Emacsen could install the package as well.
It seems that we could bring this lower bound down to Emacs 25 with
relatively small amount of effort, by:

1. Making the iso8601 dependency optional; or even better, adding it
   to GNU ELPA and adapting it to only use the new functions like
   `string-replace' on newer Emacsen.

   What do you think about this, Lars?

2. Adding browse-url to GNU ELPA, since erc-button uses its
   `browse-url-button-regexp', which was only added in Emacs 27.
   We could probably adjust erc-button to fall back onto Gnus's
   `gnus-button-url-regexp' on older Emacsen, but I think I'd
   rather not do that.

3. Not using `with-suppressed-warnings' (added in Emacs 27) on older
   Emacsen and perhaps fall back on `with-no-warnings' for the single
   use of that macro instead.

It might be possible to further lower the minimum required version of
down to the 24 series, but that would require doing something about
the uses of `define-inline' from inline.el, which was added in
Emacs 25.  Not sure if it would make sense or be possible to get
inline added to GNU ELPA for Emacsen older than 25.  Stefan?

Thanks,
amin


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-elpa-packages-erc-Add-package.patch --]
[-- Type: text/x-diff, Size: 2037 bytes --]

From 5581aa3c0fea8dabef3659928e234fc8d2e7ce82 Mon Sep 17 00:00:00 2001
From: Amin Bandali <bandali@gnu.org>
Date: Fri, 17 Sep 2021 22:27:08 -0400
Subject: [PATCH] * elpa-packages (erc): Add package

---
 elpa-packages | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index cffd9a63ca..9b54932bd5 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -158,6 +158,44 @@
   :auto-sync t)
  ("enwc"		:url "hg::https://hg.savannah.nongnu.org/hgweb/enwc/")
  ("epoch-view"		:url nil)
+ ("erc"
+  :core ("lisp/erc/erc-autoaway.el"
+         "lisp/erc/erc-backend.el"
+         "lisp/erc/erc-button.el"
+         "lisp/erc/erc-capab.el"
+         "lisp/erc/erc-dcc.el"
+         "lisp/erc/erc-desktop-notifications.el"
+         "lisp/erc/erc-ezbounce.el"
+         "lisp/erc/erc-fill.el"
+         "lisp/erc/erc-goodies.el"
+         "lisp/erc/erc-ibuffer.el"
+         "lisp/erc/erc-identd.el"
+         "lisp/erc/erc-imenu.el"
+         "lisp/erc/erc-join.el"
+         "lisp/erc/erc-lang.el"
+         "lisp/erc/erc-list.el"
+         "lisp/erc/erc-log.el"
+         "lisp/erc/erc-match.el"
+         "lisp/erc/erc-menu.el"
+         "lisp/erc/erc-netsplit.el"
+         "lisp/erc/erc-networks.el"
+         "lisp/erc/erc-notify.el"
+         "lisp/erc/erc-page.el"
+         "lisp/erc/erc-pcomplete.el"
+         "lisp/erc/erc-replace.el"
+         "lisp/erc/erc-ring.el"
+         "lisp/erc/erc-services.el"
+         "lisp/erc/erc-sound.el"
+         "lisp/erc/erc-speedbar.el"
+         "lisp/erc/erc-spelling.el"
+         "lisp/erc/erc-stamp.el"
+         "lisp/erc/erc-status-sidebar.el"
+         "lisp/erc/erc-track.el"
+         "lisp/erc/erc-truncate.el"
+         "lisp/erc/erc-xdcc.el"
+         "lisp/erc/erc.el"
+         "doc/misc/erc.texi"
+         :doc "erc.texi"))
  ("ergoemacs-mode"	:url "https://github.com/ergoemacs/ergoemacs-mode.git")
  ("excorporate"		:url nil)
  ("expand-region"	:url "https://github.com/magnars/expand-region.el")
-- 
2.17.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0001-lisp-erc-erc.el-Don-t-error-if-erc-loaddefs-does-not.patch --]
[-- Type: text/x-diff, Size: 765 bytes --]

From 085f074a2fe00648eb407f3b70532282abc1be8e Mon Sep 17 00:00:00 2001
From: Amin Bandali <bandali@gnu.org>
Date: Sat, 18 Sep 2021 12:53:59 -0400
Subject: [PATCH] * lisp/erc/erc.el: Don't error if erc-loaddefs does not
 exist.

That autoload file is created as part of the Emacs compilation
process, however we would like ERC to be usable if used outside
emacs.git (e.g. if installed from GNU ELPA).
---
 lisp/erc/erc.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 1f39644f75..7554919720 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -58,7 +58,7 @@
 
 ;;; Code:
 
-(load "erc-loaddefs" nil t)
+(load "erc-loaddefs" 'noerror 'nomessage)
 
 (require 'cl-lib)
 (require 'format-spec)
-- 
2.17.1