* [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
@ 2021-09-25 19:15 No Wayman
2021-09-25 19:28 ` No Wayman
2021-09-25 19:31 ` Bastien
0 siblings, 2 replies; 6+ messages in thread
From: No Wayman @ 2021-09-25 19:15 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
Recent changes have introduced byte-comp warnings for unknown
functions at compile time.
These warnings are "louder" now that more users are native
compiling Elisp, so one more reason to avoid them.
See attached patch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-byte-comp-function-warnings.patch --]
[-- Type: text/x-patch, Size: 3697 bytes --]
From 736e72b56b10ba451016e4cc07305d8065c02ac9 Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer <iarchivedmywholelife@gmail.com>
Date: Sat, 25 Sep 2021 15:05:08 -0400
Subject: [PATCH] Fix byte-comp function warnings
* (org.el, org-table.el org-keys.el) Declare functions for byte compiler.
---
lisp/org-keys.el | 3 ++-
lisp/org-table.el | 1 +
lisp/org.el | 5 +++++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/lisp/org-keys.el b/lisp/org-keys.el
index 8f25bda2e..2984a4f51 100644
--- a/lisp/org-keys.el
+++ b/lisp/org-keys.el
@@ -58,7 +58,6 @@
(declare-function org-clone-subtree-with-time-shift "org" (n &optional shift))
(declare-function org-columns "org" (&optional global columns-fmt-string))
(declare-function org-comment-dwim "org" (arg))
-(declare-function org-refile-copy "org" ())
(declare-function org-copy-special "org" ())
(declare-function org-copy-visible "org" (beg end))
(declare-function org-ctrl-c-ctrl-c "org" (&optional arg))
@@ -145,6 +144,8 @@
(declare-function org-promote-subtree "org" ())
(declare-function org-redisplay-inline-images "org" ())
(declare-function org-refile "org" (&optional arg1 default-buffer rfloc msg))
+(declare-function org-refile-copy "org" ())
+(declare-function org-refile-reverse "org-refile" (&optional arg default-buffer rfloc msg))
(declare-function org-reftex-citation "org" ())
(declare-function org-reload "org" (&optional arg1))
(declare-function org-remove-file "org" (&optional file))
diff --git a/lisp/org-table.el b/lisp/org-table.el
index 0bc668757..9a703d8bc 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -66,6 +66,7 @@
(declare-function org-export-install-filters "ox" (info))
(declare-function org-export-table-has-special-column-p "ox" (table))
(declare-function org-export-table-row-is-special-p "ox" (table-row info))
+(declare-function org-forward-paragraph "org" (&optional arg))
(declare-function org-id-find "org-id" (id &optional markerp))
(declare-function org-indent-line "org" ())
(declare-function org-load-modules-maybe "org" (&optional force))
diff --git a/lisp/org.el b/lisp/org.el
index e1780cf8d..630bfb19d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -158,13 +158,18 @@ Stars are put in group 1 and the trimmed body in group 2.")
(declare-function org-element-context "org-element" (&optional element))
(declare-function org-element-copy "org-element" (datum))
(declare-function org-element-create "org-element" (type &optional props &rest children))
+(declare-function org-element-extract-element "org-element" (element))
+(declare-function org-element-insert-before "org-element" (element location))
(declare-function org-element-interpret-data "org-element" (data))
(declare-function org-element-lineage "org-element" (blob &optional types with-self))
(declare-function org-element-link-parser "org-element" ())
+(declare-function org-element-map "org-element" (data types fun &optional info first-match no-recursion with-affiliated))
(declare-function org-element-nested-p "org-element" (elem-a elem-b))
(declare-function org-element-parse-buffer "org-element" (&optional granularity visible-only))
+(declare-function org-element-parse-secondary-string "org-element" (string restriction &optional parent))
(declare-function org-element-property "org-element" (property element))
(declare-function org-element-put-property "org-element" (element property value))
+(declare-function org-element-restriction "org-element" (element))
(declare-function org-element-swap-A-B "org-element" (elem-a elem-b))
(declare-function org-element-timestamp-parser "org-element" ())
(declare-function org-element-type "org-element" (element))
--
2.33.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
2021-09-25 19:15 [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)] No Wayman
@ 2021-09-25 19:28 ` No Wayman
2021-09-25 19:44 ` Bastien
2021-09-25 19:31 ` Bastien
1 sibling, 1 reply; 6+ messages in thread
From: No Wayman @ 2021-09-25 19:28 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 99 bytes --]
No Wayman <iarchivedmywholelife@gmail.com> writes:
And one more in org-attach.el.
See attached.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-byte-comp-function-warnings.patch --]
[-- Type: text/x-patch, Size: 4294 bytes --]
From 21620549a24703697d65c46bc88258cd4b2aaa80 Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer <iarchivedmywholelife@gmail.com>
Date: Sat, 25 Sep 2021 15:05:08 -0400
Subject: [PATCH] Fix byte-comp function warnings
* (org.el, org-attach.el, org-keys.el, org-table.el): Declare functions for byte compiler.
---
lisp/org-attach.el | 1 +
lisp/org-keys.el | 3 ++-
lisp/org-table.el | 1 +
lisp/org.el | 5 +++++
4 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/lisp/org-attach.el b/lisp/org-attach.el
index 162a01e5e..c2d71514c 100644
--- a/lisp/org-attach.el
+++ b/lisp/org-attach.el
@@ -40,6 +40,7 @@
(require 'org-id)
(declare-function dired-dwim-target-directory "dired-aux")
+(declare-function dired-get-marked-files "dired" (&optional localp arg filter distinguish-one-marked error))
(declare-function org-element-property "org-element" (property element))
(declare-function org-element-type "org-element" (element))
(declare-function org-inlinetask-goto-beginning "org-inlinetask" ())
diff --git a/lisp/org-keys.el b/lisp/org-keys.el
index 8f25bda2e..2984a4f51 100644
--- a/lisp/org-keys.el
+++ b/lisp/org-keys.el
@@ -58,7 +58,6 @@
(declare-function org-clone-subtree-with-time-shift "org" (n &optional shift))
(declare-function org-columns "org" (&optional global columns-fmt-string))
(declare-function org-comment-dwim "org" (arg))
-(declare-function org-refile-copy "org" ())
(declare-function org-copy-special "org" ())
(declare-function org-copy-visible "org" (beg end))
(declare-function org-ctrl-c-ctrl-c "org" (&optional arg))
@@ -145,6 +144,8 @@
(declare-function org-promote-subtree "org" ())
(declare-function org-redisplay-inline-images "org" ())
(declare-function org-refile "org" (&optional arg1 default-buffer rfloc msg))
+(declare-function org-refile-copy "org" ())
+(declare-function org-refile-reverse "org-refile" (&optional arg default-buffer rfloc msg))
(declare-function org-reftex-citation "org" ())
(declare-function org-reload "org" (&optional arg1))
(declare-function org-remove-file "org" (&optional file))
diff --git a/lisp/org-table.el b/lisp/org-table.el
index 0bc668757..9a703d8bc 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -66,6 +66,7 @@
(declare-function org-export-install-filters "ox" (info))
(declare-function org-export-table-has-special-column-p "ox" (table))
(declare-function org-export-table-row-is-special-p "ox" (table-row info))
+(declare-function org-forward-paragraph "org" (&optional arg))
(declare-function org-id-find "org-id" (id &optional markerp))
(declare-function org-indent-line "org" ())
(declare-function org-load-modules-maybe "org" (&optional force))
diff --git a/lisp/org.el b/lisp/org.el
index e1780cf8d..630bfb19d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -158,13 +158,18 @@ Stars are put in group 1 and the trimmed body in group 2.")
(declare-function org-element-context "org-element" (&optional element))
(declare-function org-element-copy "org-element" (datum))
(declare-function org-element-create "org-element" (type &optional props &rest children))
+(declare-function org-element-extract-element "org-element" (element))
+(declare-function org-element-insert-before "org-element" (element location))
(declare-function org-element-interpret-data "org-element" (data))
(declare-function org-element-lineage "org-element" (blob &optional types with-self))
(declare-function org-element-link-parser "org-element" ())
+(declare-function org-element-map "org-element" (data types fun &optional info first-match no-recursion with-affiliated))
(declare-function org-element-nested-p "org-element" (elem-a elem-b))
(declare-function org-element-parse-buffer "org-element" (&optional granularity visible-only))
+(declare-function org-element-parse-secondary-string "org-element" (string restriction &optional parent))
(declare-function org-element-property "org-element" (property element))
(declare-function org-element-put-property "org-element" (element property value))
+(declare-function org-element-restriction "org-element" (element))
(declare-function org-element-swap-A-B "org-element" (elem-a elem-b))
(declare-function org-element-timestamp-parser "org-element" ())
(declare-function org-element-type "org-element" (element))
--
2.33.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
2021-09-25 19:15 [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)] No Wayman
2021-09-25 19:28 ` No Wayman
@ 2021-09-25 19:31 ` Bastien
1 sibling, 0 replies; 6+ messages in thread
From: Bastien @ 2021-09-25 19:31 UTC (permalink / raw)
To: No Wayman; +Cc: emacs-orgmode
No Wayman <iarchivedmywholelife@gmail.com> writes:
> Recent changes have introduced byte-comp warnings for unknown
> functions at compile time.
> These warnings are "louder" now that more users are native compiling
> Elisp, so one more reason to avoid them.
>
> See attached patch.
Applied, thanks a lot.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
2021-09-25 19:28 ` No Wayman
@ 2021-09-25 19:44 ` Bastien
2021-09-25 19:55 ` No Wayman
0 siblings, 1 reply; 6+ messages in thread
From: Bastien @ 2021-09-25 19:44 UTC (permalink / raw)
To: No Wayman; +Cc: emacs-orgmode
No Wayman <iarchivedmywholelife@gmail.com> writes:
> No Wayman <iarchivedmywholelife@gmail.com> writes:
>
> And one more in org-attach.el.
That's not just org-attach.el, right? The patch does not apply
either in the bugfix or in the main branch. Could you resend it,
also wrapping the body of the ChangeLog at <80 lines? M-x
change-log-mode RET can help. TIA!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
2021-09-25 19:44 ` Bastien
@ 2021-09-25 19:55 ` No Wayman
2021-09-25 20:46 ` Bastien
0 siblings, 1 reply; 6+ messages in thread
From: No Wayman @ 2021-09-25 19:55 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
Bastien <bzg@gnu.org> writes:
> That's not just org-attach.el, right? The patch does not apply
> either in the bugfix or in the main branch. Could you resend
> it,
> also wrapping the body of the ChangeLog at <80 lines? M-x
> change-log-mode RET can help. TIA!
Sorry. Didn't realize the first patch had already been committed,
so I rolled the change into that.
Separated the org-attach patch. See attached.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-attach-byte-comp-patch --]
[-- Type: text/x-patch, Size: 907 bytes --]
From c5b77469c2fbff5d9fd25fcf9025b8a354406256 Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer <iarchivedmywholelife@gmail.com>
Date: Sat, 25 Sep 2021 15:05:08 -0400
Subject: [PATCH] org-attach: Fix byte-comp function warning
* (org-attach.el): Declare function for byte compiler.
---
lisp/org-attach.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/org-attach.el b/lisp/org-attach.el
index 162a01e5e..c2d71514c 100644
--- a/lisp/org-attach.el
+++ b/lisp/org-attach.el
@@ -40,6 +40,7 @@
(require 'org-id)
(declare-function dired-dwim-target-directory "dired-aux")
+(declare-function dired-get-marked-files "dired" (&optional localp arg filter distinguish-one-marked error))
(declare-function org-element-property "org-element" (property element))
(declare-function org-element-type "org-element" (element))
(declare-function org-inlinetask-goto-beginning "org-inlinetask" ())
--
2.33.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)]
2021-09-25 19:55 ` No Wayman
@ 2021-09-25 20:46 ` Bastien
0 siblings, 0 replies; 6+ messages in thread
From: Bastien @ 2021-09-25 20:46 UTC (permalink / raw)
To: No Wayman; +Cc: emacs-orgmode
No Wayman <iarchivedmywholelife@gmail.com> writes:
> Bastien <bzg@gnu.org> writes:
>
>> That's not just org-attach.el, right? The patch does not apply
>> either in the bugfix or in the main branch. Could you resend it,
>> also wrapping the body of the ChangeLog at <80 lines? M-x
>> change-log-mode RET can help. TIA!
>
> Sorry. Didn't realize the first patch had already been committed, so I
> rolled the change into that.
> Separated the org-attach patch. See attached.
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-25 20:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-25 19:15 [PATCH] Declare functions for byte compiler [9.5 (9.5-g769a55 @ /home/n/.emacs.d/straight/build/org/)] No Wayman
2021-09-25 19:28 ` No Wayman
2021-09-25 19:44 ` Bastien
2021-09-25 19:55 ` No Wayman
2021-09-25 20:46 ` Bastien
2021-09-25 19:31 ` Bastien
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.