Should fancy-startup-screen really set browse-url-browser-function?

Should fancy-startup-screen really set browse-url-browser-function?

[John Ankarström]

The startup screen for GUI Emacs (fancy-startup-screen) apparently sets
browse-url-browser-function to eww-browse-url. The setting is
buffer-local, but it affects any commands that the user might manually
run from the startup screen.

For example, I have a command that I use for searching the web:

(defun misc-search-web (query)
 "Search the web with `browse-url'."
 (interactive "sQuery: ")
 (browse-url (format "https://www.google.com/search?q=%s&ie=UTF-8&gbv=1"
                     (url-encode-url query))))

It is bound to C-c w, and I make frequent use of it, but I have been
surprised that it opens eww sometimes (namely, when the startup screen
is active).

When users ask how to set the default browser for Emacs, they're often
told to customize browse-url-browser-function, but there's no mention in
the docstring of the fact that this variable is commonly(?) overridden.

(I say "commonly" not because I know it is common, but because the
built-in startup screen does so, which sets an example for others to
follow.)

Should fancy-startup-screen (and major modes in general) really override
browse-url-browser-function?

Re: Should fancy-startup-screen really set browse-url-browser-function?

[Juri Linkov]

> Should fancy-startup-screen (and major modes in general) really override
> browse-url-browser-function?

Maybe this would be better?

diff --git a/lisp/startup.el b/lisp/startup.el
index 3ac7532053..70c95af88f 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -2276,7 +2276,9 @@ normal-about-screen
   (insert "\tHow to report bugs and contribute improvements to Emacs\n\n")
 
   (insert-button "GNU and Freedom"
-		 'action (lambda (_button) (describe-gnu-project))
+		 'action (lambda (_button)
+                           (let ((browse-url-browser-function 'eww-browse-url))
+                             (describe-gnu-project)))
 		 'follow-link t)
   (insert "\t\tWhy we developed GNU Emacs and the GNU system\n")
 
-- 

etc.

Re: Should fancy-startup-screen really set browse-url-browser-function?

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

>> Should fancy-startup-screen (and major modes in general) really override
>> browse-url-browser-function?
>
> Maybe this would be better?

Makes sense to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no