bug#53419: 27.1; Occur edit mode should also handle RET properly before the line number

bug#53419: 27.1; Occur edit mode should also handle RET properly before the line number

[ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors]

After the line number pressing RET jumps to the location even
in occur edit mode which is good behavior.

But if you press RET on the line number or before it in edit
mode then it inserts a newline, messing up the occur buffer.

RET should always jump to the location when pressed anywhere
on the line.

bug#53419: 27.1; Occur edit mode should also handle RET properly before the line number

[Lars Ingebrigtsen]

ndame <laszlomail@protonmail.com> writes:

> After the line number pressing RET jumps to the location even
> in occur edit mode which is good behavior.
>
> But if you press RET on the line number or before it in edit
> mode then it inserts a newline, messing up the occur buffer.
>
> RET should always jump to the location when pressed anywhere
> on the line.

I'm not sure I understand the issue.  Could you give a recipe to
reproduce the problem, starting from "emacs -Q"?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#53419: 27.1; Occur edit mode should also handle RET properly before the line number

[ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> I'm not sure I understand the issue. Could you give a recipe to
> reproduce the problem, starting from "emacs -Q"?

1. start Emacs with -Q, you are in scratch
2. M-x occur  and type the word "file" for the regexp
3. you have one match from the initial scratch message
4. switch to the occur window and press e for edit mode,
   then go to before the line number on the line (2:) and
   press RET
6. RET inserts a newline character which does not make sense
   for occur edit, because the matches are line based

RET should always go the the match location like in non-edit
mode, wherever the cursor is on the matching line, because
adding newlines does not really make sense, not even in edit
mode.

bug#53419: 27.1; Occur edit mode should also handle RET properly before the line number

[Lars Ingebrigtsen]

ndame <laszlomail@protonmail.com> writes:

> 1. start Emacs with -Q, you are in scratch
> 2. M-x occur  and type the word "file" for the regexp
> 3. you have one match from the initial scratch message
> 4. switch to the occur window and press e for edit mode,
>    then go to before the line number on the line (2:) and
>    press RET
> 6. RET inserts a newline character which does not make sense
>    for occur edit, because the matches are line based

Thanks; I've now fixed this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#53419: 27.1; Occur edit mode should also handle RET properly before the line number

[ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>
> Thanks; I've now fixed this in Emacs 29.
>

Thanks.

BTW, in the meantime I noticed that the occur buffer is also
modified  incorrectly if you press RET on the matched
line in occur edit mode (so not on the line number, but
somewhere on the text after it).