all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Iñigo Serna" <inigoserna@gmx.com>
To: emacs-devel@gnu.org
Subject: eshell/addpath broken since commit dea24a0f7d
Date: Tue, 25 Jan 2022 19:49:49 +0100	[thread overview]
Message-ID: <87tudrwsre.fsf@gmx.com> (raw)

Hi

It looks `eshell/addpath' is broken in master since commit 
dea24a0f7d [1].

$ src/emacs --debug-init -Q --eval "(progn (require 'eshell) 
(eshell/addpath \"~/bin\"))"

Debugger entered--Lisp error: (wrong-number-of-arguments (4 . 4) 
3)
  eshell--do-opts("addpath" ((98 "begin" nil prepend "add path 
  element at beginning") (104 "help" nil nil "display this usage 
  message") :usage "[-b] PATH\nAdds the given PATH to $PATH.") 
  ("~/bin"))
  eshell/addpath("~/bin")


Thanks,
-- 
Iñigo Serna


[1]
commit dea24a0f7d4ae42fae912dd724a770678054989a
Author: Jim Porter <jporterbugs@gmail.com>
Date:   Mon Jan 24 21:03:42 2022 -0800

    Don't manipulate args in-place for 'eshell-eval-using-options'
    
    This is necessary for preserve the original arguments to 
    forward on to
    :external commands.  Previously, when :preserve-args was also 
    set, the
    original argument list could be altered, changing the meaning 
    of the
    command.



             reply	other threads:[~2022-01-25 18:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 18:49 Iñigo Serna [this message]
2022-01-25 19:19 ` eshell/addpath broken since commit dea24a0f7d Jim Porter
2022-01-25 19:50   ` Iñigo Serna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tudrwsre.fsf@gmx.com \
    --to=inigoserna@gmx.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.