From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53839: 29.0.50; Strange bug causes tool bar to be overwritten Date: Tue, 08 Feb 2022 08:46:07 +0800 Message-ID: <87tudadw34.fsf@yahoo.com> References: <87h79bhwbg.fsf.ref@yahoo.com> <87h79bhwbg.fsf@yahoo.com> <87r18eg5z5.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23278"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: 53839@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 02:02:56 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHEuG-0005qt-5d for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 02:02:56 +0100 Original-Received: from localhost ([::1]:50074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHEuE-0008Tr-K3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Feb 2022 20:02:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHEes-000346-Te for bug-gnu-emacs@gnu.org; Mon, 07 Feb 2022 19:47:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHEes-0001Qz-Dc for bug-gnu-emacs@gnu.org; Mon, 07 Feb 2022 19:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHEes-0000tk-7B for bug-gnu-emacs@gnu.org; Mon, 07 Feb 2022 19:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 00:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53839 X-GNU-PR-Package: emacs Original-Received: via spool by 53839-submit@debbugs.gnu.org id=B53839.16442811883406 (code B ref 53839); Tue, 08 Feb 2022 00:47:02 +0000 Original-Received: (at 53839) by debbugs.gnu.org; 8 Feb 2022 00:46:28 +0000 Original-Received: from localhost ([127.0.0.1]:44302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHEeK-0000ss-9P for submit@debbugs.gnu.org; Mon, 07 Feb 2022 19:46:28 -0500 Original-Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]:42565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHEeG-0000sX-8t for 53839@debbugs.gnu.org; Mon, 07 Feb 2022 19:46:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644281177; bh=GEe9j4A8Z5sr2MKS3gkH3Pr60ZaI2oowLnSM1DPFAZo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=lt0vlvU28PBFVwNSvKOq/LntN+qBBmydpZ0cGtNfs17yNXR7LWusny/t81iuJXII3YfjJ7drStp4RlFUdyamUJk7cuRaYyw1JYeRyCaDihhqQ0oCa6sb6ipSZPZDFIUKhIldl7oyNNmNCsI8R3KekTXBxZ28SYO/+Le5Aq5S+psFBw/Z2MOFHTFwa+dORmku260s4oWLp/5Wy6jJCkoPmqmWPgi1XXB/yFVSqpR3jvIRRYBhcdoEVBGcSY2XvyaYD2r75sligCcttzZFwaY3SPeeggxR36aBVqlVebKLpPcDd9OHy9M5qmPgF/wXQayTOAo+xQ2wg59ziG6gFXnwcg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644281177; bh=8H5+x8H8lbiiShPSO49Nmh+bBVhVLF8XnATXibbqOsW=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Xq87p6WkQlGq/3zysowwnF632o795UItL52/Gul/P+MQievoEyn2mIa4qaD9Z1yfxTnZCtkY60AvslcfD1z8t+YN6+s4oYdvIPAAJ8HdWIvWOK/4KYWl4hFrIoy2soIX1M7lCshmaH1PsaYy9SAhDsynMMekly+BQPAF4eS6IwOjd9VB8CuP/8k44JsnTtXQTTVhG7qSjJoZOMVhBl1/CNVjkS8dOetTOpnCf45Soiw6+qkjjditldmpFLaHxTuj7JbEMGVTQOpcrIm3SvbY+lQUTTdArlPxmosIZEUEQJuYx1g5VqeDm2n/8S7az/6UVeJOthjzrmI9dBodZUBRMw== X-YMail-OSG: FuLmKm4VM1kXqYaScQFIMcmFY2ZyDZ0M.XzlZQ6yqfXAj1tegV5wOeIRNrV8L7n kZ_mlvZt1PbC0wE1WrVMjJFoR7BmYuPbH0tdAQqNPRmn.uMAjPgt35B.4SKjE1CyLYJihc18dczt pxdmuXd08smuV1JJ3vYZVE5L86SnA.4YBxyq91dELmFfAwvApagYCtx5_VaR7F_tUzKewiKJ9WoF 69VMvkNK9zQrQFoYrfvH2KAtNg66QSqUsXWU5_JEdVkEFfVJZnry5xX7_8gZMh4yr.jnQLKO4vmg vwvbparv9qsWQdzhfyAONlQUTuk1GKBuzVAsINalixAnI4ijzmTXgLTUYn5.aOLpBGTd.ENP0YRh 2vuqt647en0Vg.8t9mUijTYJfL73nHcIHnesNpNd3CWXXRPJk9dTPKvz8ADvdrnPOhGfoaAq_m4b NghXZACt9QPM9Yt9HeSWHBBDRLNqyAp58.AvGbftWcZ1WQJ5MM56M3T4x4Ktf7eeECBM3_jmDK9V tt3qjq3VriS_l3jyQt0n0n96wAatcaIWw8qyb1I9v4TAYo6xaOlj8N4jUviZExF7sbn3GzLMi3Rs iIgDU.b0rtjlL5ruYxMEQqcsU8.ooozZAAbKFCK8dTZsMoJRHTWcCw1XS3REYzTp2nQIvrv3URcw by2GslEK_y555RXy8wGXTrCbW38R7_hamWqCIm2V6vut8Awx_SOQUrhPtl3A8sg05ce.crAao789 HMd2woa8rccKtyOrqhQkXat1dxMnSwTawpbRDL_BThWr_EDBKzTWzLLOtyqHe7w1sOe9TIScX0MU s_tKhH9NEPsvJAk39vPkPRKLULC.FX2CnKPWTaF1m7 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Tue, 8 Feb 2022 00:46:17 +0000 Original-Received: by kubenode517.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID f0dfaef18f3a75f604f7fac163c4f150; Tue, 08 Feb 2022 00:46:11 +0000 (UTC) In-Reply-To: (martin rudalics's message of "Mon, 7 Feb 2022 16:49:57 +0100") X-Mailer: WebService/1.1.19711 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226299 Archived-At: martin rudalics writes: > /* 2021 REMIX: Don't call widget_update_wm_size_hints here since on > GNOME shell get_wm_shell may fail to produce the wmshell widget. > As a consequence, no size hints get set before we issue our resize > request, mutter (presumably) refuses to resize the outer window as > requested and we end up with a wrong initial frame size. > > It's not clear whether other calls of update_wm_hints are affected > as well but not calling widget_update_wm_size_hints here seems > sufficient to fix the bug. */ > > /** #ifdef USE_X_TOOLKIT **/ > /** if (f->output_data.x->widget) **/ > /** { **/ > /** widget_update_wm_size_hints (f->output_data.x->widget); **/ > /** return; **/ > /** } **/ > /** #endif **/ > > which works around that problem. (I didn't try your fix but am > convinced that it gets the initial frame height wrong.) I fixed the calls to widget_update_wm_size_hints on master, and it fixes the bug, so if you're happy with that fix I'll close this bug now. Thanks.