all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 53839@debbugs.gnu.org
Subject: bug#53839: 29.0.50; Strange bug causes tool bar to be overwritten
Date: Tue, 08 Feb 2022 08:46:07 +0800	[thread overview]
Message-ID: <87tudadw34.fsf@yahoo.com> (raw)
In-Reply-To: <fa3ab9bd-4472-16ad-d823-0a030d25a01b@gmx.at> (martin rudalics's message of "Mon, 7 Feb 2022 16:49:57 +0100")

martin rudalics <rudalics@gmx.at> writes:

>   /* 2021 REMIX: Don't call widget_update_wm_size_hints here since on
>      GNOME shell get_wm_shell may fail to produce the wmshell widget.
>      As a consequence, no size hints get set before we issue our resize
>      request, mutter (presumably) refuses to resize the outer window as
>      requested and we end up with a wrong initial frame size.
>
>      It's not clear whether other calls of update_wm_hints are affected
>      as well but not calling widget_update_wm_size_hints here seems
>      sufficient to fix the bug.  */
>
> /** #ifdef USE_X_TOOLKIT **/
> /**   if (f->output_data.x->widget) **/
> /**     { **/
> /**       widget_update_wm_size_hints (f->output_data.x->widget); **/
> /**       return; **/
> /**     } **/
> /** #endif **/
>
> which works around that problem.  (I didn't try your fix but am
> convinced that it gets the initial frame height wrong.)

I fixed the calls to widget_update_wm_size_hints on master, and it fixes
the bug, so if you're happy with that fix I'll close this bug now.

Thanks.





  reply	other threads:[~2022-02-08  0:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87h79bhwbg.fsf.ref@yahoo.com>
2022-02-07  9:15 ` bug#53839: 29.0.50; Strange bug causes tool bar to be overwritten Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-07 13:23   ` martin rudalics
2022-02-07 13:29     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-07 15:49       ` martin rudalics
2022-02-08  0:46         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-02-08  8:57           ` martin rudalics
2022-02-08  9:22             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tudadw34.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=53839@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.