From: Robert Pluim <rpluim@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: Brian Leung <leungbk@posteo.net>,
Lars Ingebrigtsen <larsi@gnus.org>,
53853@debbugs.gnu.org
Subject: bug#53853: [PATCH] Don't use string-replace in flymake
Date: Tue, 08 Feb 2022 11:19:03 +0100 [thread overview]
Message-ID: <87tud964q0.fsf@gmail.com> (raw)
In-Reply-To: <CALDnm537vn56-gmKFxOr3pZ1VyVhx6Xd+koj=qU-uaUKqyyg1w@mail.gmail.com> ("João Távora"'s message of "Tue, 8 Feb 2022 09:52:34 +0000")
>>>>> On Tue, 8 Feb 2022 09:52:34 +0000, João Távora <joaotavora@gmail.com> said:
João> On Tue, Feb 8, 2022 at 9:26 AM Robert Pluim <rpluim@gmail.com> wrote:
>> >>>>> On Tue, 08 Feb 2022 07:16:40 +0100, Lars Ingebrigtsen <
>> larsi@gnus.org> said:
>>
Lars> Brian Leung <leungbk@posteo.net> writes:
>> >> OK, I've updated the patch per your suggestions. I've also made the
>> >> commit apply to the emacs-28 branch, as opposed to the master
>> branch.
>>
Lars> Thanks; pushed to emacs-28.
>>
>> Iʼm not au fait with how core packages work, does this require a bump
>> in flymake's package version?
João> Yes, Robert, I believe so. Else the core package won't get regenerated into
João> GNU ELPA.
OK
João> What _doesn't_ require a bump is, for example, `eglot.el` usage of it. So
João> if you
João> bump flymake.el to, say, 1.9 now and eglot.el is still asking for 1.8, I
João> think package.el
João> will pull in the latest one regardless and the problem for eglot.el users
João> will be fixed.
João> I suspect though, that this problem only happened because the user was using
João> the straight.el package manager, which will try to fetch the very latest
João> (i.e.
João> not go through GNU ELPA as package.el does).
João> Anyway, thanks for fixing this.
I donʼt think weʼre quite there yet. Let's see what Eli says in the
other thread.
Robert
--
prev parent reply other threads:[~2022-02-08 10:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 16:11 bug#53853: [PATCH] Don't use string-replace in flymake Brian Leung
2022-02-07 17:32 ` Robert Pluim
2022-02-08 2:17 ` Brian Leung
2022-02-08 6:16 ` Lars Ingebrigtsen
2022-02-08 8:21 ` Robert Pluim
2022-02-08 8:28 ` Brian Leung
2022-02-08 8:35 ` Robert Pluim
2022-02-08 9:20 ` João Távora
2022-02-08 9:50 ` Robert Pluim
2022-02-08 9:54 ` João Távora
2022-02-08 9:58 ` João Távora
2022-02-08 13:03 ` Eli Zaretskii
2022-02-08 13:18 ` João Távora
2022-02-08 13:54 ` Eli Zaretskii
2022-02-08 14:09 ` João Távora
2022-02-08 15:07 ` Robert Pluim
2022-02-08 15:30 ` João Távora
2022-02-08 15:47 ` Robert Pluim
2022-02-08 15:51 ` João Távora
2022-02-08 16:02 ` Robert Pluim
2022-02-08 16:43 ` João Távora
2022-02-08 17:02 ` Robert Pluim
2022-02-08 17:55 ` Dmitry Gutov
2022-02-08 17:08 ` Dmitry Gutov
2022-02-09 8:55 ` Robert Pluim
2022-02-08 9:52 ` João Távora
2022-02-08 10:19 ` Robert Pluim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tud964q0.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=53853@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=larsi@gnus.org \
--cc=leungbk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.