From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54435: The test mailcap-parsing-and-mailcap-mime-info forgets to restore the HOME environment variable Date: Thu, 17 Mar 2022 16:12:34 +0100 Message-ID: <87tubwsjdp.fsf@gnus.org> References: <878rt81x70.fsf@sperrhaken.name> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38628"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54435@debbugs.gnu.org To: Felix Dietrich Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 17 16:13:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUroN-0009nC-US for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Mar 2022 16:13:11 +0100 Original-Received: from localhost ([::1]:57112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUroM-0005Y2-R0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Mar 2022 11:13:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUroE-0005UU-9k for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 11:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUroE-0000Fs-0V for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 11:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nUroD-0000wL-OI for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 11:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Mar 2022 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54435-submit@debbugs.gnu.org id=B54435.16475299673580 (code B ref 54435); Thu, 17 Mar 2022 15:13:01 +0000 Original-Received: (at 54435) by debbugs.gnu.org; 17 Mar 2022 15:12:47 +0000 Original-Received: from localhost ([127.0.0.1]:54974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUrnz-0000vf-4r for submit@debbugs.gnu.org; Thu, 17 Mar 2022 11:12:47 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:48948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUrnx-0000vJ-5X for 54435@debbugs.gnu.org; Thu, 17 Mar 2022 11:12:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yHIUe4U4IcK9sd6R6xvWRFKG2vgh6EsCH7LCQAP0mNk=; b=Y2JiT2z1NCO1r3QlFeRPEbnQel 4jykhWKrj3QoO0Pofs6++ml4biyObOyqwdWLCgW0TUpkyO3u1YaNJxfov3S4fhRL3Pk3+HDm6fPPz KrDDb/TAPZRPrEwUFWENKyUaw89HMFM50SgTc570aAn8OXqWgCnim5PtmoHguHweQbV0=; Original-Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUrnn-0000W5-Uo; Thu, 17 Mar 2022 16:12:38 +0100 In-Reply-To: <878rt81x70.fsf@sperrhaken.name> (Felix Dietrich's message of "Thu, 17 Mar 2022 15:16:19 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228487 Archived-At: Felix Dietrich writes: > The patch wraps the test in a =E2=80=98let=E2=80=99 and =E2=80=98unwind-p= rotect=E2=80=99 to restore the > value of the environment variable after the test has been run. Thanks. I've now applied a similar change to Emacs 29, but used `with-environment-variables' instead of let/unwind-protect. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no