From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 54481@debbugs.gnu.org, dick <dick.r.chiang@gmail.com>
Subject: bug#54481: 29.0.50; [PATCH] Rewrite hl-line
Date: Tue, 22 Mar 2022 08:25:55 +0800 [thread overview]
Message-ID: <87tubqkf3g.fsf@yahoo.com> (raw)
In-Reply-To: <87y213mjf7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 21 Mar 2022 16:09:32 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Makes sense to me, so I've applied the patch to Emacs 29.
Now, ironically, that patch introduced at least two incompatible changes
which are likely to affect users: `hl-line' is no longer a face, and
`hl-line-face' (a variable) has been replaced by the face.
Of course, with no updates to the version field, NEWS, or the
documentation. I tried to fix it, but I might've missed something.
> The one thing I was unsure about was things like this:
>
>> -(defun hl-line-unload-function ()
>> - "Unload the Hl-Line library."
>
> We normally don't remove functions like this, but just make them
> obsolete. But in this case it seems unlikely to me that anybody would
> actually ever use these functions, so I didn't alter that part. But if
> anybody complains, we should take them the normal obsoletion route.
With that change, unloading the hl-line feature leaves stray overlays
around. Which I also fixed by restoring the old definition.
This function is called by Emacs automatically when hl-line is unloaded,
and is not for users to call anyway.
Thanks.
next prev parent reply other threads:[~2022-03-22 0:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 15:52 bug#54481: 29.0.50; [PATCH] Rewrite hl-line dick
2022-03-21 15:09 ` Lars Ingebrigtsen
2022-03-22 0:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-03-23 8:48 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-23 11:35 ` dick
2022-03-23 11:55 ` Lars Ingebrigtsen
2022-03-23 13:02 ` Eli Zaretskii
2022-03-22 3:13 ` Michael Heerdegen
2022-03-22 14:12 ` dick
2022-03-22 14:12 ` dick
2022-03-22 14:59 ` Lars Ingebrigtsen
2022-03-22 14:14 ` Lars Ingebrigtsen
2022-03-22 14:24 ` dick
2022-03-22 14:35 ` Lars Ingebrigtsen
2022-03-23 2:21 ` Michael Heerdegen
2022-03-24 3:23 ` Michael Heerdegen
2022-03-24 3:39 ` Michael Heerdegen
2022-03-24 3:53 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-24 4:42 ` Michael Heerdegen
2022-03-24 4:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-24 5:13 ` Michael Heerdegen
2022-03-24 5:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-25 3:45 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tubqkf3g.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=54481@debbugs.gnu.org \
--cc=dick.r.chiang@gmail.com \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.