From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: process-file instead of call-process in proced.el? Date: Fri, 25 Mar 2022 12:46:06 +0100 Message-ID: <87tubmi7b5.fsf@gmx.de> References: <835yo2cyj9.fsf@gnu.org> <83v8w2b9wn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4497"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Filipp Gunbin , winkler@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 25 12:53:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXiVq-00014T-Rx for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Mar 2022 12:53:50 +0100 Original-Received: from localhost ([::1]:49814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXiVp-0001jd-T4 for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Mar 2022 07:53:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXiOU-0003qj-QK for emacs-devel@gnu.org; Fri, 25 Mar 2022 07:46:14 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:44299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXiOS-0001bF-VK; Fri, 25 Mar 2022 07:46:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1648208767; bh=ifRYfL4yAuduNE8e/y83acOdiGDynTK78K/32Ji9ov8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=LZBrSj5IUDArthvtc0pJvdKZ7IgymsUbjXRWHcT5mdQN4zxUrl7aRuiO5M4obOMt8 0AuUdQmo2xmkXAlCjJq4xiFxqNeYp19oq7ZlzRK22CHJczz89taaVVzEzcCfQA7548 x8G4Gt4cdNxS6+jFducsYvVOJj8ZZb4uH7AeA+KQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.118.40]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MAfUe-1nMflH2m1w-00B0WT; Fri, 25 Mar 2022 12:46:07 +0100 In-Reply-To: <83v8w2b9wn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 25 Mar 2022 13:31:52 +0300") X-Provags-ID: V03:K1:j1CnKdgUU5C/iFpW18M13LFDVuRTLtF53LZk0p1mB0F/PymtSVy 7VxS+jV5tEwrnR9j7/jEszS5kSxMHLZ1SqamB7XK7Sx910BFqkt7rVCnuEANmjn7fmdENcE tSAxH/7xCjkk6mE7EBle+cV8HtEn5L40AdTuA75YpF7EopbidDmvDhH4x2HItRsGdiMVqKa OF08y1Q5zoHyEVjuJnjXw== X-UI-Out-Filterresults: notjunk:1;V03:K0:bza/wcr6D4w=:u8vjFePvWPCgxM1JdtSMxD VVFQDxgKDamVAZr+51iUcMUpTIlYpvMuZCKTtW5DdxPgGdHrSmpzewfSJNvi+kit+1Y516zKA qV1uEx7SVO3lWibSxKdAVxWZiQJ8J7QogW0A/erJhgNLySgrm65m7pNLB6WoEkWLcaLlvKtS6 61HSftReNdGsNfEl/tQwPaakhCapf3YoUz/zYAsvQ+Gb07yMOabsYml5R6sLROdwJ5EgYv6VS WLbfPZ1Du/guiV6P/iB7rzzWirfHOorRI2fej4G7DhtRY6Wh1yOp/ylWP97gOCtoh8RSNKacw xVXfNJzAfiLhGpUiEOixtbX7hoh2v1Vt4Wo03qBAIJrVAdWuDi867jjgSNTQ8lPZBCZimkdVT FekS7ElBFNq23/crsQdxoYQg7lUYhh9rWhGz9tb6hs22DsPXrji9er5KoU2wRWNo48jxtkc3P bPhEpIWDgiaCCXB9ZIJ44EAnW/gRNK/b9FxdIt43s32m8h5SmGuWa0oWDSIhrKUw/F8ZCfLQo sQEC2CxUXEtFjm9IUmMIWSauMFlcsuimkaVKod5YEnZRd1CPgo4XADjqeAHIsWH18XQhJ6h1T jbDqoffbxpQugwcoUXDrP3NNKhgNwlgWlt1GpKvWz5v6jzezu7/3eAXpsJyxTPpP9ZjBsctB9 t0YCv0sfCUxBzHcUrKFg1lELhcnAoeUsBS+vJKJDjxuYEs90mZg4fuwzDJkVgIuLWzKsNkjkX b5NE/qePYVF7Fo3vt97G9cCQ2WMH/iP+jITyVLkmUrnFdN8t2CC7zyv+wOb/WQ0JqK/lBob8 Received-SPF: pass client-ip=212.227.17.21; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287445 Archived-At: Eli Zaretskii writes: >> The patch only changes call-process to process-file, to support file >> handlers. Setting "kill" into proced-signal-function is a user >> customization. > > Sorry, from my POV fixing something means making it work as correctly > as we can reasonably do. If it didn't work correctly before, we > should fix that as well, as part of any work on the relevant code. I > understand that, if the doing TRT is complicated, it could be left to > a separate patch, but in this case it isn't complicated at all. > > So let's fix this part of proced to work on all supported platforms, > okay? I don't understand why an external "kill" process is applied. Couldn't we simply call always `signal-process'? A comment in `proced-send-signal' recommends this already. Then we could give `signal-process' a handler, like `interrupt-process' has already. (Well, we would need a mean to indicate, that a process-id is meant for a remote host.) Best regards, Michael.