From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54921: eww/url mishandles IDN over proxy Date: Thu, 14 Apr 2022 15:15:14 +0200 Message-ID: <87tuavn6vx.fsf@gnus.org> References: <87bkx44q3v.fsf@igel.home> <87czhko3xg.fsf@gnus.org> <87bkx4yw98.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38950"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54921@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 14 15:16:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nezKW-0009wc-LY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Apr 2022 15:16:12 +0200 Original-Received: from localhost ([::1]:53844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nezKV-0000jY-HO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Apr 2022 09:16:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nezKM-0000jP-JL for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 09:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nezKM-0007A1-B6 for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 09:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nezKM-0002la-60 for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 09:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Apr 2022 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54921 X-GNU-PR-Package: emacs Original-Received: via spool by 54921-submit@debbugs.gnu.org id=B54921.164994212610590 (code B ref 54921); Thu, 14 Apr 2022 13:16:02 +0000 Original-Received: (at 54921) by debbugs.gnu.org; 14 Apr 2022 13:15:26 +0000 Original-Received: from localhost ([127.0.0.1]:55599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nezJm-0002kk-C4 for submit@debbugs.gnu.org; Thu, 14 Apr 2022 09:15:26 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:40282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nezJl-0002kY-Cf for 54921@debbugs.gnu.org; Thu, 14 Apr 2022 09:15:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4h1UMRtVUUS/6chBQSi8NiXvsozPYierZmzaFOmuS7Q=; b=Gf8tam4xexThrBOboT/rcuubEh H9N3HAhfJxEnQMllra3zHSkd9XvgzRNpnlxVunNB6D862ugyYOmrp7irjo/rja4jnsE/PjpNrA8Nn wfJpk/XPKkEMRWcyZ8mf2hX2DgY4KVsVF0SgElWo/YaZryLJS/RLC1kXF/Yur/AL/cR0=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nezJc-0001fv-Jn; Thu, 14 Apr 2022 15:15:18 +0200 In-Reply-To: <87bkx4yw98.fsf@igel.home> (Andreas Schwab's message of "Thu, 14 Apr 2022 09:11:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229863 Archived-At: Andreas Schwab writes: > I have set https_proxy=http://localhost:8118/ in the environment, which > is picked up by url to set url-proxy-services. Hm, right... I'm not at all familiar with this code, so here's a stab in the dark. Does this fix the problem? diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index daeba17031..22e003d22d 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -1405,10 +1405,12 @@ url-https-proxy-connect (and proxy-auth (concat "Proxy-Authorization: " proxy-auth "\r\n"))) "\r\n") - (url-host url-current-object) + (url-http--encode-string + (puny-encode-domain (url-host url-current-object))) (or (url-port url-current-object) url-https-default-port) - (url-host url-current-object)))) + (url-http--encode-string + (puny-encode-domain (url-host url-current-object)))))) (defun url-https-proxy-after-change-function (_st _nd _length) (let* ((process-buffer (current-buffer)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no