all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 54921@debbugs.gnu.org
Subject: bug#54921: eww/url mishandles IDN over proxy
Date: Thu, 14 Apr 2022 15:15:14 +0200	[thread overview]
Message-ID: <87tuavn6vx.fsf@gnus.org> (raw)
In-Reply-To: <87bkx4yw98.fsf@igel.home> (Andreas Schwab's message of "Thu, 14 Apr 2022 09:11:47 +0200")

Andreas Schwab <schwab@linux-m68k.org> writes:

> I have set https_proxy=http://localhost:8118/ in the environment, which
> is picked up by url to set url-proxy-services.

Hm, right...

I'm not at all familiar with this code, so here's a stab in the dark.
Does this fix the problem?

diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index daeba17031..22e003d22d 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -1405,10 +1405,12 @@ url-https-proxy-connect
               (and proxy-auth
                    (concat "Proxy-Authorization: " proxy-auth "\r\n")))
             "\r\n")
-    (url-host url-current-object)
+    (url-http--encode-string
+     (puny-encode-domain (url-host url-current-object)))
     (or (url-port url-current-object)
         url-https-default-port)
-    (url-host url-current-object))))
+    (url-http--encode-string
+     (puny-encode-domain (url-host url-current-object))))))
 
 (defun url-https-proxy-after-change-function (_st _nd _length)
   (let* ((process-buffer (current-buffer))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-04-14 13:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 21:42 bug#54921: eww/url mishandles IDN over proxy Andreas Schwab
2022-04-14  1:21 ` Lars Ingebrigtsen
2022-04-14  7:11   ` Andreas Schwab
2022-04-14 13:15     ` Lars Ingebrigtsen [this message]
2022-04-14 13:52       ` Andreas Schwab
2022-04-14 13:55         ` Lars Ingebrigtsen
2022-04-14 14:14           ` Andreas Schwab
2022-04-14 14:15             ` Lars Ingebrigtsen
2022-04-14 15:49               ` Andreas Schwab
2022-04-14 15:54                 ` Lars Ingebrigtsen
2022-04-14 16:03                   ` Andreas Schwab
2022-04-14 16:10                     ` Lars Ingebrigtsen
2022-04-14 16:45                       ` Andreas Schwab
2022-04-14 17:14                         ` Lars Ingebrigtsen
2022-04-14 17:39                           ` Andreas Schwab
2022-04-15  8:35                             ` Lars Ingebrigtsen
2022-04-15 11:25                               ` Andreas Schwab
2022-04-15 11:38                                 ` Lars Ingebrigtsen
2022-04-15 11:46                                   ` Andreas Schwab
2022-04-16 15:03                                     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuavn6vx.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=54921@debbugs.gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.