From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Please review: rewrite sql-interactive-remove-continuation-prompt Date: Sat, 30 Apr 2022 13:53:47 +0200 Message-ID: <87tuaa3hys.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4120"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 30 13:55:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nklhK-0000ta-6l for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Apr 2022 13:55:38 +0200 Original-Received: from localhost ([::1]:44498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nklhI-0004GG-Ib for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Apr 2022 07:55:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nklfe-0002Ts-Fq for emacs-devel@gnu.org; Sat, 30 Apr 2022 07:53:54 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:37218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nklfd-0007M5-0t for emacs-devel@gnu.org; Sat, 30 Apr 2022 07:53:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ryhDTa1vBT2N8wLIOwQdTVwMxRkwZj7ffboDgU0lKLg=; b=riRMeXoM7FK5hF1JMdL5qES9hQ 6VhtckShkHbZWYiRWlFYnyj9hEpCpTT0vrCL8tqctGvKY1/GlYzKS0/bl36PBKS9HsX1cJVPrcL1u lKW05hIALUYSvFdlpDIzCtC0IRQBAv1T9zssKkItMT6h5O1qAToD8No6qiaHX9z+mCPw=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nklfY-0007W3-DC for emacs-devel@gnu.org; Sat, 30 Apr 2022 13:53:50 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEVAOkVCPEU5Mzj/ //9zPAoYAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YEHgsmDxa7pQcAAAG1SURBVCjPLdDBbptAEAbg MUol6hMgjJKcMFIlvE9BLR/cnJqKQTGn+IBk71Ng1FZ0T4klI9cngupqmafMLITD7n7amX9HwK04 WFVoEbUhgBI6otiirrVKEKJsiSq+iUqwhaYRpMGWH9CMp7WBVVetYCzryqAtRcs9E8UFOgx5Xa+3 FbVeHZmAWKKlY09HtUGMvg2MkGqwHfQBHB2ZAOlimoC3iEoZA+lHfxl6NpzyBUz1E0Do2zczRHgQ Nvd4n60B09IHTNPEwRmsV2UwwdRP3BWjiAOuwMS5Qdh9pRHfQwQxVwGfuUteQexU4xjg8gRyR4x0 liKnUUy/z3P/V4pFwePQ//N25iJuEEhQUxfOHZchyI0KVOpPTCLscVrV37JXxAIh31Ont+mnDPMT kKQu3uLwAfXU0ZxPj9mGIY5avPzNMOOyPZl/XQfDO9xEpKibFTwOcQ8jvuOpOaBRDLoNe4a+KHFP nfvlzIP2zSUJ9LGUmnt0cy6yn3RIFyaA6BmlKlfuCIE5vYg/I+h4laXsR8imlw0dPm5ee156kAMu V16GcUiKi9n0gAepzDY3+Pcjvzd4ewd89O+M+1oisAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0w NC0zMFQxMTozODoxNSswMDowMMwAyCsAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDQtMzBUMTE6 Mzg6MTUrMDA6MDC9XXCXAAAAAElFTkSuQmCC X-Now-Playing: New Order's _Brotherhood_: "Angel Dust" In-Reply-To: (Filipp Gunbin's message of "Sat, 30 Apr 2022 00:51:34 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289050 Archived-At: Filipp Gunbin writes: > Previously we were anchoring the prompt search regexps to start/end of > string (` and '), but now just search for regexps as they are. Current > regexps in sql.el all anchor to the beginning of line (^, not `). The > change is indended, as prompts may appear anywhere in the output. I think that makes change, but before pushing, can you add some test cases for these things? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no