all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Subject: Re: Please review: rewrite sql-interactive-remove-continuation-prompt
Date: Sat, 30 Apr 2022 13:53:47 +0200	[thread overview]
Message-ID: <87tuaa3hys.fsf@gnus.org> (raw)
In-Reply-To: <m2pmkz8snt.fsf@fastmail.fm> (Filipp Gunbin's message of "Sat, 30 Apr 2022 00:51:34 +0300")

Filipp Gunbin <fgunbin@fastmail.fm> writes:

> Previously we were anchoring the prompt search regexps to start/end of
> string (` and '), but now just search for regexps as they are.  Current
> regexps in sql.el all anchor to the beginning of line (^, not `).  The
> change is indended, as prompts may appear anywhere in the output.

I think that makes change, but before pushing, can you add some test
cases for these things?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  parent reply	other threads:[~2022-04-30 11:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 21:51 Please review: rewrite sql-interactive-remove-continuation-prompt Filipp Gunbin
2022-04-29 22:19 ` Filipp Gunbin
2022-04-30 11:53 ` Lars Ingebrigtsen [this message]
2022-05-02 16:29   ` Filipp Gunbin
2022-05-03 10:35     ` Lars Ingebrigtsen
2022-05-03 11:16       ` Filipp Gunbin
2022-05-03 11:19         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuaa3hys.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.