From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56355: 29.0.50; Implement file-parent-directory Date: Mon, 04 Jul 2022 13:08:22 +0200 Message-ID: <87tu7x6spl.fsf@gnus.org> References: <0f199ed7-abef-d74c-b5fd-c9c81978c143@gmail.com> <83wncvbuht.fsf@gnu.org> <8735fj3e9n.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19249"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "56355@debbugs.gnu.org" <56355@debbugs.gnu.org> To: daanturo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 04 13:09:51 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8Jxf-0004r1-44 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jul 2022 13:09:51 +0200 Original-Received: from localhost ([::1]:44812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8Jxe-0008DS-32 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jul 2022 07:09:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Jwt-00079Z-4t for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 07:09:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8Jws-00040x-MW for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 07:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8Jws-0003vK-F9 for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 07:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2022 11:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56355 X-GNU-PR-Package: emacs Original-Received: via spool by 56355-submit@debbugs.gnu.org id=B56355.165693291815031 (code B ref 56355); Mon, 04 Jul 2022 11:09:02 +0000 Original-Received: (at 56355) by debbugs.gnu.org; 4 Jul 2022 11:08:38 +0000 Original-Received: from localhost ([127.0.0.1]:46280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JwU-0003uM-H0 for submit@debbugs.gnu.org; Mon, 04 Jul 2022 07:08:38 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JwP-0003u1-0d for 56355@debbugs.gnu.org; Mon, 04 Jul 2022 07:08:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GqVdCrmtKDBf/1de6i+toYNlPsKr6hk/fozacBrclhM=; b=PromdIKAE7npC1EXg8q6YAIjUL rS+y8xlZarj9S61kyxcqyVyjdy4Qsbgvwz1JLTa9/mYwLNjLt0wWb1NirvsCBuqJlIn9P7C0nbNpi GRjgTKmkpo/VniTAr4WW6be+Yg0V10TKob8d1/Y/+aedGftePV02gcpAstdA7NPLO9zo=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8JwF-0006aQ-Vc; Mon, 04 Jul 2022 13:08:26 +0200 In-Reply-To: (daanturo@gmail.com's message of "Sun, 3 Jul 2022 01:24:12 +0700") X-Now-Playing: Joe Jackson's _Body and Soul_: "The Verdict" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236050 Archived-At: daanturo writes: > So I wonder in this case, with both FILENAME and the found parent's names > expanded, we can opt to use `equal`/`string=` instead of `file-equal-p` for > better performance? I think file-equal-p is safer here, so I've pushed your patch to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no